Prevent double file cache with instant search.

[core-ai-bot]

Issue by abose Wednesday Jul 22, 2015 at 06:27 GMT Originally opened as https://github.com/adobe/brackets/issues/11436

---

When instant search file cache is present, brackets doesn't need to keep the file cache. This will free up a lot of memory in the brackets side. Currently instant search keeps the file cache in node. currently ProjectModel.prototype.getAllFiles will issue a this._getAllFilesCache - which is a double cacheing [the other file cache being in node] that could be avoided.

[core-ai-bot]

Comment by abose Thursday Aug 06, 2015 at 13:20 GMT

---

Marked as high priority as this could halve the cache size in large projects.

[core-ai-bot]

Comment by sahildua2305 Tuesday Oct 18, 2016 at 19:22 GMT

---

@petetnt I'd like to work on this. Can you please provide some hint about how to get started with this?

[core-ai-bot]

Comment by petetnt Tuesday Oct 18, 2016 at 19:42 GMT

---

@sahildua2305 The search cache is initialized in FindInFiles.js#L838 which calls ProjectManager.getAllFiles which calls ProjectModel.prototype.getAllFiles here which leads to the situation which@abose describes.

There are some utils you can use to see if Instant Search is enabled here, but I think it might need some additional checks to see that the file cache is actually there before skipping it in the ProjectModel.

[core-ai-bot]

Comment by sahildua2305 Tuesday Oct 18, 2016 at 19:50 GMT

---

Not sure I understand it correctly. Where should the check (to find if file cache is already there) go?

[core-ai-bot]

Comment by petetnt Tuesday Oct 18, 2016 at 19:52 GMT

---

Not quite sure yet myself either 😹 I think the answer lies in either FindInFiles or ProjectModel.

[core-ai-bot]

Comment by sahildua2305 Tuesday Oct 18, 2016 at 19:54 GMT

---

Ok! I will look into it. Let me know if you find out something on this though. Thanks 😄