brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

v1.8 crashes and, in general is less stable than 1.7 it seems to me. #13727

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by K-Thompson Thursday Nov 17, 2016 at 01:08 GMT Originally opened as https://github.com/adobe/brackets/issues/12918


Prerequisites

For more information on how to write a good bug report read here For more information on how to contribute read here

Description

Not a bug report, but rather a report on my experience so far using Release 1.8 build 1.8.0-17108.

I've been using Brackets daily since about sprint 36, on 2 Windows 7 computers, One with 8gb ram and the other 4gb. I uninstalled 1.7 and did "fresh" install of 1.8. Fresh in quotes because I did not delete the \users\\AppData\Roaming\Bracket folder.

v1.8 has crashed everyday on the one computer after various amounts of time of use, but never in less than an hour. One the notebook, that I use during a train commute of about 45 minutes, Brackets has never crashed. My sense is, there is some type resource recovery problem. Just prior to each crash, the CPU is just about pegged to max utilization.

WHen it crashes, the files visible in the editor close. But the frame stays open. I have to use task manager to kill the Bracket's process.

Also, code hints still do not work well, not does code completion. I've reported these issues here before.

No extensions have changed since v1.7.

The debugger console does report these 2 errors.

main.js:210 Exception in 'activeEditorChange' listener on Object TypeError: Cannot read property 'file' of null TypeError: Cannot read property 'file' of null

main.js:210 Exception in 'currentFileChange' listener on Object TypeError: Cannot read property 'file' of null TypeError: Cannot read property 'file' of null

But they do not seem like they are responsible for the crashes, only because those errors are visible as soon as Brackets open, even prior to doing anything.

[Description of the bug or feature]

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior: [What you expected to happen]

Actual behavior: [What actually happened]

Versions

Please include the OS and what version of the OS you're running. Please include the version of Brackets. You can find it under Help -> About Brackets (Windows and Linux) or Brackets -> About Brackets (macOS)

core-ai-bot commented 3 years ago

Comment by zaggino Thursday Nov 17, 2016 at 03:09 GMT


We have a tern running in a web worker, instead of a node implementation which would make more sense. That could be the culprit.

core-ai-bot commented 3 years ago

Comment by ficristo Thursday Nov 17, 2016 at 19:04 GMT


@K-Thompson is your platform a 32 bit one? If so could you try to replace the node executable you find in C:\Program Files\Brackets with the one you can dowload from http://nodejs.org/dist/v6.3.1/win-x86/?

For the exception you get could you try this workaround? https://github.com/adobe/brackets/issues/12792#issuecomment-252992877

core-ai-bot commented 3 years ago

Comment by s5rockhoppers Thursday Nov 17, 2016 at 19:31 GMT


That seemed to fix the problem...

core-ai-bot commented 3 years ago

Comment by K-Thompson Saturday Nov 19, 2016 at 11:27 GMT


@ficristo - no, platform is 64bits Windows 7.

For the mentioned exceptions, clearing the recent list did eliminate them - per #12792

While I have your attention, I'll also mention that I see some deprecated warnings in the debugger. Not sure if I'm an exception (due to upgrading since the sprints) or if these are common and known:

PreferencesManager.convertPreferences() has been deprecated. Please upgrade to the current Preferences system (https://github.com/adobe/brackets/wiki/Preferences-System#conversion-from-the-pre-36-preferences-system).

Fail to nomalize Cmd-Shift-] main.js:196 Fail to nomalize Cmd-Shift-[

I'm just now noticing the link for converting the pre 36 preferences. But the converting option itself now seems to be deprecated. Is there a way to convert my preference file?

And later edit....

I just did another install of 1.8. This time I used Windows uninstall and also deleted the \Users\AppData\Roaming\Brackets folder. I still get above warnings.

Should I have deleted another folder?

core-ai-bot commented 3 years ago

Comment by ficristo Saturday Nov 19, 2016 at 12:21 GMT


We use React so this is expected:

Download the React DevTools for a better development experience: https://fb.me/react-devtools

There are some issues/PR about removing old preferences system, one removed this will disappear. About the preferences, AFAIK they should be already converted. The deprecation is only about a feature that will go away as a remainder for extension authors who used the old preferences system.

/utils/DeprecationWarning.js:88 PreferencesManager.convertPreferences() has been deprecated. Please upgrade to the current Preferences system (https://github.com/adobe/brackets/wiki/Preferences-System#conversion-from-the-pre-36-preferences-system).
    at Object.convertPreferences (/preferences/PreferencesManager.js:323:28)
    at Object.eval (/utils/Resizer.js:557:24)
    at Object.context.execCb (file:///C:/Program%20Files%20(x86)

These depends on your keyboard layout, and so they can appear (I think there are already a couple of issues about it)

/command/KeyBindingManager.js:578 Fail to nomalize Cmd-Shift-]
/command/KeyBindingManager.js:578 Fail to nomalize Cmd-Shift-[

The warnings about usage of $().on/off() and Mustache are, most likely, coming from your extensions. There is nothing you can do but opening issue againsts them. (From the logs there should be some hint about which extension is throwing the deprecation warning) So no, you aren't the only one who gets them

core-ai-bot commented 3 years ago

Comment by K-Thompson Saturday Nov 19, 2016 at 12:39 GMT


@ficristo

The warnings about usage of $().on/off() and Mustache are, most likely, coming from your extensions.

Confirmed. I edited my comment and removed them before I saw your reply.

core-ai-bot commented 3 years ago

Comment by nicksoph Tuesday Dec 20, 2016 at 10:14 GMT


replacement of node version - worked for me on a 32bit win10 machine

core-ai-bot commented 3 years ago

Comment by phamnutuyetan Monday Mar 20, 2017 at 11:57 GMT


@ficristo thanks dude, it works for me

core-ai-bot commented 3 years ago

Comment by ficristo Monday Mar 20, 2017 at 19:04 GMT


You can try https://github.com/adobe/brackets/releases/tag/release-1.9-prerelease-2 were the win32 bit is fixed. And maybe also fixes the crashes.