search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

Multibrowser Live Preview Support for All browsers #13945

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by sobisht Monday Jul 17, 2017 at 06:03 GMT Originally opened as https://github.com/adobe/brackets/pull/13570

Currently, Multibrowser live preview is not support in browsers namely IE and Edge (Reason: The multibowser live preview is implemented on WebSockets, and IE & Edge gives security error for Websocket implementation.)

Following changes have been done for this implementation:

  1. Transport layer have been changed from Websockets to socket.io. Node modules related to socket.io have been added and express module have been added in package.json to create socket.io server.

  2. Port for socket.io server have been made configurable with default value as 8123. It can be configured in brackets preference by "livedevmulti.socketPort".

  3. Object.assign has been replaced by manual copying of JSON files. Object.assign is not supported in IE11.

@swmitra@saurabh95@busykai@petetnt@ficristo Please review and provide feedback.

sobisht included the following code: https://github.com/adobe/brackets/pull/13570/commits

core-ai-bot commented 3 years ago

Comment by saurabh95 Thursday Sep 07, 2017 at 13:16 GMT

@sobisht Could you please address the review comments, so that we can merge it asap.