search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Open getting started project on startup instead of src #1440

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by njx Tuesday Aug 28, 2012 at 00:43 GMT Originally opened as https://github.com/adobe/brackets/pull/1468

There is now a samples/ folder (next to the src/ folder) that contains the getting started material, with subfolders for each locale. (The content is not yet finalized or localized.)

The easiest way (for now) for us to pick the right folder per locale is to leverage the require i18n plugin. To do so, we created urls.js files in the nls/ folder that work the same way as the strings.js files. It's a bit of silly extra infrastructure just to get the right locale mapping; eventually we probably need to write our own fallback logic for this kind of thing rather than leveraging require.

Note that currently we don't auto-open the index.html file on first launch. I have a question out to Adam as to whether we should (I think it would make sense).

njx included the following code: https://github.com/adobe/brackets/pull/1468/commits

core-ai-bot commented 3 years ago

Comment by njx Tuesday Aug 28, 2012 at 00:44 GMT

Assigned to@gruehle

core-ai-bot commented 3 years ago

Comment by gruehle Tuesday Aug 28, 2012 at 15:30 GMT

It would be nice if index.html could be selected when the project is opened. The simplest way to do this may be to add index.html to the working set (the first file in the working set is automatically selected/opened when the app starts up).

core-ai-bot commented 3 years ago

Comment by njx Tuesday Aug 28, 2012 at 22:29 GMT

@gruehle Ready for re-review. I fixed up the quotes and added the auto-open index.html functionality.

core-ai-bot commented 3 years ago

Comment by gruehle Tuesday Aug 28, 2012 at 23:02 GMT

Looks good. Merging.