search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

Missing CSS code hints for logical properties & values #14472

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by predaioan Saturday May 11, 2019 at 19:48 GMT Originally opened as https://github.com/adobe/brackets/issues/14788

Working on a RLT web app i noticed that Brackets CSS code hints seem to be missing almost all the CSS logical properties used in rtl development. For example CSSProperties.json contains the margin top/right/left/bottom but not the:

margin-block
margin-block-end
margin-block-start
margin-inline
margin-inline-end
margin-inline-start

All CSS logical properties are to be found at: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Logical_Properties

Should I attempt a pull request updating with all those properties/values?

Using Windows 7 x64, Brackets v1.13

core-ai-bot commented 3 years ago

Comment by shubhsnov Sunday May 12, 2019 at 06:58 GMT

I do see that these values are experimental as of yet and might not even be supported on all browsers (hover over the icon next to the property). The page itself discourages the use in production code.

By giving them as hints, we in spirit would encourage developers to use these non-standard properties. @swmitra what do you say?

As for pull request, since this is a very targetted ask and might be extremely relevant to your use case, I think it better to have this as a separate extension which can have these extra hints. You can upload it to the extension registry for others to use as well. This will also allow you to disable the feature and revert back to using the standard hints as and when you please.

core-ai-bot commented 3 years ago

Comment by predaioan Monday May 13, 2019 at 18:58 GMT

You are right, these properties & values are w3c editor's draft. Perhaps an extension would be the best alternative at this point in time. However, given that:

we could make the case for giving this another thought or at least keeping an eye on it :) There are many CSS properties/values that are not fully supported but used plenty in production in various cases. For example content for Android WebView.

core-ai-bot commented 3 years ago

Comment by shubhsnov Tuesday May 14, 2019 at 10:01 GMT

@narayani28@swmitra Any thoughts on this?

core-ai-bot commented 3 years ago

Comment by sprintr Wednesday May 15, 2019 at 21:33 GMT

Not in favor of adding experimental properties to the hints. I guess making an extension would be a better approach.