[CLOSED] Quick Open enhancements & API cleanup

core-ai-bot commented 3 years ago

Issue by peterflynn Wednesday Sep 05, 2012 at 23:43 GMT Originally opened as https://github.com/adobe/brackets/pull/1565

Allow search() to return a result object instead of a string; this value is now passed to itemFocus/Select() instead of a raw DOM node. Upshot: no longer need to stash metadata in the list item HTML and parse it back out later.
Better ranking of search results: prioritize into tiers (favoring exact matches, then matches starting at start of the string); sort identical filenames by path instead of arbitrary order
Expose a public API to open a particular search mode (making it cleaner to add entirely new search modes with a new prefix character)
Fix a few minor bugs:
- In HTML id search, attrs like "data-button-id" created many false positives (due to "id" suffix)
- Filenames with no extension were truncated
- JS and CSS search were showing results in reverse-alphabetical order
Clarify / fix inaccuracies in documentation

peterflynn included the following code: https://github.com/adobe/brackets/pull/1565/commits

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Sep 06, 2012 at 23:26 GMT

Done with initial code review.

core-ai-bot commented 3 years ago

Comment by peterflynn Sunday Sep 09, 2012 at 07:45 GMT

@redmunds: Code changes pushed. I think I've fixed or responded to all of the comments above -- please let me know if you'd like any other changes.

core-ai-bot commented 3 years ago

Comment by redmunds Monday Sep 10, 2012 at 16:44 GMT

Looks good. Merging.

brackets-archive / bracketsIssues