search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Inline CSS editor UI breaks if menu bar height changes when switching files #1568

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by joelrbrandt Monday Sep 10, 2012 at 05:06 GMT Originally opened as https://github.com/adobe/brackets/issues/1606

If the Brackets window is sized appropriately, the height of the menu bar can change when the user switches files. For example, if one file has a long name and one has a short name, the menu bar will "wrap" onto two lines for the long name but not for the short name.

If an inline editor is open and the user switches files and then switches back, and the menu bar resizes as a result, then the inline editor UI gets messed up.

Steps to reproduce:

  1. Make an html file with a long name and a css file with a short name.
  2. Size brackets so that when the html file is displayed, the menu bar is two lines long, but when the css file is displayed, the menu bar is only one line long
  3. Switch to the html file
  4. Open an inline editor
  5. Switch to css file
  6. Switch back to html file

Result:

Inline editor UI is messed up

Expected:

Not messed up

Images:

  1. Initial inline editor with tall menu bar: http://cl.ly/image/2916261x3l2w
  2. Switch to file with short menu bar: http://cl.ly/image/0i022G43171B
  3. Switch back to first file, ui messed up: http://cl.ly/image/3A1w3J2A1G39
core-ai-bot commented 3 years ago

Comment by peterflynn Monday Sep 10, 2012 at 05:54 GMT

We do refresh the editor height whenever the toolbar height changes (see the call to resizeEditor() in DocumentCommandHandlers), so in theory this should behave similarly to the editor's height changing due to a window resize.

core-ai-bot commented 3 years ago

Comment by pthiess Wednesday Sep 12, 2012 at 16:41 GMT

Reviewed -@jasonsanjose We may think about a centralized broadcast notification mechanism on layout changes. Might be part of the effort to remove Flexbox - may chat with NJ for ideas.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Oct 03, 2012 at 19:36 GMT

Oops. Didn't mean to auto close. FBNC@joelrbrandt.

core-ai-bot commented 3 years ago

Comment by joelrbrandt Thursday Oct 04, 2012 at 17:15 GMT

Confirming fixed. Thanks@DennisKehrig !

core-ai-bot commented 3 years ago

Comment by DennisKehrig Monday Oct 08, 2012 at 18:03 GMT

Thanks for the reviews!