[CLOSED] Brackets in your web browser

brackets-archive / bracketsIssues

Archive of issues in brackets.

0 stars 0 forks source link

[CLOSED] Brackets in your web browser #1725

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jdiehl Thursday Oct 04, 2012 at 14:06 GMT Originally opened as https://github.com/adobe/brackets/pull/1770

This pull request will allow brackets to run inside your web browser (Chrome & Safari). To get it running:

Install node modules (run npm install in src/proxyServer)
Run the node proxy (run node proxyServer insrc/`)
Open src/index.html in your web browser or place src/ on your web server

Note that the proxy must run on the same server as the web server!

This hack is the result of the London Hackathon!

jdiehl included the following code: https://github.com/adobe/brackets/pull/1770/commits

core-ai-bot commented 3 years ago

Comment by jasonsanjose Thursday Oct 04, 2012 at 21:41 GMT

Initial review complete. Great work!

When the other half of the team gets back from from JSConf, we'll want to discuss what our next steps will be.

core-ai-bot commented 3 years ago

Comment by jdiehl Friday Oct 05, 2012 at 11:02 GMT

Thanks for the quick response and the comments!

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Oct 10, 2012 at 22:33 GMT

We discussed this at the standup today and would like to do the following:

Treat this work as our initial research spike for our in-browser/cloud user story https://trello.com/c/61ChEQmJ
Create a wiki page to document the current issues and limitations in-browser. e.g. The brackets.fs proxy would eventually be replaced with another file API to access files from Git, Dropbox, local file system, etc. You might want to look at Trello for stories that begin with "BROWSER: " to get an idea of the feature set we had in mind during our initial product planning.
Create a new branch in the brackets repo for this pull request.
Identify any changes that we can merge to master and separate them from the in-browser specific changes.

I'll take another pass through this pull request to see what we can merge to master and what we think should be in the separate in-browser branch. Sound like a good plan?

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Oct 10, 2012 at 23:26 GMT

2nd pass complete. Let us know how you feel about the plan moving forward.

core-ai-bot commented 3 years ago

Comment by jdiehl Thursday Oct 11, 2012 at 16:06 GMT

I separated the changes out of in-browser that Jason suggested into #1813 and addressed the other comments in here. When you think it is ready, let me know and I can send a new pull request to a separate branch (or just work some git magic and merge it directly ^^)

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Oct 17, 2012 at 16:50 GMT

Sorry for the late follow up, I was out on PTO. I've pushed up a new in-browser branch that you can submit a pull request to.