search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Update hidden lines when syncing a change from the current editor into the document #1771

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by njx Thursday Oct 11, 2012 at 22:23 GMT Originally opened as https://github.com/adobe/brackets/pull/1817

After edits that affect an inline editor, we try to resync the set of hidden/shown lines in CodeMirror to match what we think the visible range to be. But we were only doing that in the case where the edit came from a different editor. We also need to do it when the edit comes from our own editor. Ordinary edits can't affect lines outside of the visible range, but undo/redo can (because they can cause changes to other areas of the underlying document).

njx included the following code: https://github.com/adobe/brackets/pull/1817/commits

core-ai-bot commented 3 years ago

Comment by njx Thursday Oct 11, 2012 at 22:23 GMT

This is for #1031.

core-ai-bot commented 3 years ago

Comment by njx Thursday Oct 11, 2012 at 22:23 GMT

@peterflynn Could you take a look at this one?

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Oct 12, 2012 at 18:29 GMT

Done reviewing. Looks good aside from those two small things.

core-ai-bot commented 3 years ago

Comment by njx Friday Oct 12, 2012 at 20:31 GMT

Thanks for the feedback. Ready for final review.

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Oct 12, 2012 at 20:35 GMT

Great! Merging now.