search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Added basic suporrt for reading files #18

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by tvoliter Wednesday Dec 14, 2011 at 23:54 GMT Originally opened as https://github.com/adobe/brackets/pull/13

Added the following shell classes to support file reading

Implemented File() call on FileEntry to get file object to pass to FileReader.readAsText

The basics are now there that we should be able to display the contents of a file in Brackets

Areas I am still working on in this area: read file error handling read file unit tests a more robust event object for FileReader

tvoliter included the following code: https://github.com/adobe/brackets/pull/13/commits

core-ai-bot commented 3 years ago

Comment by gruehle Thursday Dec 15, 2011 at 00:38 GMT

I see you've moved the file classes into brackets.fs.* These should probably go into bracket.* instead. The "brackets.fs" package is where the low-level file io functions live, and the "fs" name is borrowed from node.js.

core-ai-bot commented 3 years ago

Comment by tvoliter Thursday Dec 15, 2011 at 00:40 GMT

Thanks Glenn. I just fixed this and did another push into my branch. The file io classes are now in NativeFileSystem so they don't pollute the brackets.fs space. NJ said he'd review and merge into master

Ty

-----Original Message----- From: Glenn Ruehle [mailto:reply@reply.github.com] Sent: Wednesday, December 14, 2011 4:38 PM To: Ty Voliter Subject: Re: [brackets] Added basic suporrt for reading files (#13)

I see you've moved the file classes into brackets.fs.* These should probably go into bracket.* instead. The "brackets.fs" package is where the low-level file io functions live, and the "fs" name is borrowed from node.js.

Reply to this email directly or view it on GitHub: https://github.com/adobe/brackets/pull/13#issuecomment-3154815