search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] French: punctuation error in PROJECT_SETTING_BASE_URL #2082

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by Tania-Jiacomini Tuesday Nov 20, 2012 at 09:14 GMT Originally opened as https://github.com/adobe/brackets/issues/2163

As per French punctuation rules, please add a non-breaking space before the colon in "Live Preview Base URL:"

Correct FR: "URL de base de l’Aperçu en direct :"

Source screen: https://www.dropbox.com/lightbox/home/Brackets%20Localization?select=PROJECT_SETTING_BASE_URL.jpg

Target screen: https://www.dropbox.com/lightbox/home/Brackets%20Localization?select=PROJECT_SETTING_BASE_URL_FR.jpg

core-ai-bot commented 3 years ago

Comment by ArturOledzki Tuesday Nov 20, 2012 at 10:17 GMT

There is no colon in source and target strings in ALF. Please verify.

core-ai-bot commented 3 years ago

Comment by Zhanxin Friday Nov 23, 2012 at 07:23 GMT

I have captured the string with the newest build 0.17.0-4651. Please refer to: https://www.dropbox.com/s/3jut1r29qk0s56h/PROJECT_SETTING_BASE_URL_0.17.0-4651.jpg?m

core-ai-bot commented 3 years ago

Comment by njx Monday Nov 26, 2012 at 19:03 GMT

Reviewed. Does this require any action by the core team?

core-ai-bot commented 3 years ago

Comment by ArturOledzki Tuesday Nov 27, 2012 at 07:54 GMT

Yes, We need your help. There is no colon in ALF for this occurrence: https://www.dropbox.com/s/c1uolux24u0wqa2/ID_PROJECT_SETTING_BASE_URL.jpg?m Is the colon added automatically?

core-ai-bot commented 3 years ago

Comment by njx Tuesday Nov 27, 2012 at 08:07 GMT

Yes, it looks like the colon is hardcoded into the dialog template. You could just add a space at the end of the French string though.

core-ai-bot commented 3 years ago

Comment by ArturOledzki Tuesday Nov 27, 2012 at 08:22 GMT

Space added. Please verify.

core-ai-bot commented 3 years ago

Comment by Zhanxin Wednesday Nov 28, 2012 at 07:25 GMT

I have captured the string with the newest build 0.17.0-4699. Please refer to: https://www.dropbox.com/s/mjzqxt1fgeuon49/PROJECT_SETTING_BASE_URL_17_4699.jpg?m

core-ai-bot commented 3 years ago

Comment by RaymondLim Wednesday Nov 28, 2012 at 16:39 GMT

@Zhanxin I'm not sure what you want to point out with the new screenshot. I do see the space before : in two separate strings. I also see the label centered above the input text field. Are you pointing out the layout issue? This has to be fixed by the core team.@redmunds Can you take a look at the screenshot and see you can fix the layout issue for French version? Also if you can move the hard-coded : into their related strings, it might be better for localization to translate those strings.

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Nov 28, 2012 at 17:49 GMT

The label and input field should be be on the same line. The problem is that the label string is longer than the English version. There was some extra room provided for longer strings in other languages, but this string is much longer than the English string.

This is a standard modal dialog, so making it wider would make all modal dialogs wider, and I'd like to try to avoid that. We can reduce the width of the input field, but that's a huge difference to make up.

@Zhanxin@RaymondLim Can the French string be made shorter?

Yes, it would be easy to move : from the template to the string.

core-ai-bot commented 3 years ago

Comment by RaymondLim Wednesday Nov 28, 2012 at 19:51 GMT

@redmunds Can you shorten the input field a little bit and remove the margin or padding on left and right? Currently, it has some wasted space after the text field. If you can, then we won't need localizer to shorten the label. If you can't and still need a shorter string, can you tell Yoko how many characters they need to cut?

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Nov 28, 2012 at 21:35 GMT

There is only a 10px margin around the text field. Any less than that will look too cramped. So, that cannot be reduced.

core-ai-bot commented 3 years ago

Comment by RaymondLim Wednesday Nov 28, 2012 at 21:41 GMT

The actual cause is text-alignment:center on the container div. If I change it to right, then we don't have wasted space to the right of the text field. I also try with 4px margin and it looks fine to me.

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Nov 28, 2012 at 21:48 GMT

That is required to center the overall content. This splits the extra space on the left and right instead of putting it all on one side or the other. Add a few characters to the English string and you will see what I mean.

I will reduce the width of the input field.

core-ai-bot commented 3 years ago

Comment by ybayer Thursday Nov 29, 2012 at 02:01 GMT

IQE team, could you take a screenshot once the pull request #2243 was merged into the master? The original issue was about missing a space around the colon, but Raymond from the core team pointed out that the layout doesn't look right. The label and edit field are not positioned on the same line. Randy reduced the edit field width, but we may still have to make the translation shorter if the problem persists.

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Nov 29, 2012 at 02:06 GMT

There is no need for any further screen shots. I fixed the bug for French, but we won't merge it in until after Sprint 17.

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Dec 05, 2012 at 15:34 GMT

Marking Fixed But Not Closed (FBNC).@Zhanxin@Tania-Jiacomini please verify that this is fixed.

core-ai-bot commented 3 years ago

Comment by Tania-Jiacomini Wednesday Dec 05, 2012 at 15:56 GMT

Space added before colon, issue is linguistically fixed, thanks.

core-ai-bot commented 3 years ago

Comment by Zhanxin Thursday Dec 06, 2012 at 06:27 GMT

Verify this issue with build Brackets 0.17.0-4745, fixed. Please refer to the screenshot: https://www.dropbox.com/s/4tbzwqk5wxl84wc/PROJECT_SETTING_BASE_URL_17_4745.jpg?m