search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Add expand/collapse triangle icons to Find in Files search results headings #2118

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Monday Nov 26, 2012 at 08:24 GMT Originally opened as https://github.com/adobe/brackets/pull/2206

Although this is "bonus work," I'm hoping to squeeze it into Sprint 17 to aid discoverability of the existing expand/collapse feature.

This also cleans up how jsTreeSprites.svg is used:

I've compared screenshots of the project tree to verify that this doesn't affect the appearance of its triangles at all.

peterflynn included the following code: https://github.com/adobe/brackets/pull/2206/commits

core-ai-bot commented 3 years ago

Comment by redmunds Monday Nov 26, 2012 at 21:38 GMT

Done with initial review.

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Nov 27, 2012 at 02:11 GMT

@redmunds: Thanks for squeezing in a review btw!

I've pushed up the cleanup for the long line. Let me know if you still want any of the other changes -- I'll keep an eye out tonight.

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Nov 27, 2012 at 03:28 GMT

Looks good. Merging.