search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Adding Arabic translation #2222

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by apolikamixitos Monday Dec 10, 2012 at 21:56 GMT Originally opened as https://github.com/adobe/brackets/pull/2323

I finished the Arabic translation of brackets, and i wanted just to inform you that i pulled the change on 'arabic-lang' branch.

As you may know, Arabic is read from RTL (Right-To-Left) like Hebrew, i followed a topic that was discussing this matter on Google Groups.

https://groups.google.com/d/topic/brackets-dev/R9lpXQN02wk/discussion

I noticed that the RTL will be supported in the next release of CodeMirror v3. until then, here is the Arabic translation, feel free if you want to integrate it to the build now or maybe in the next release (there is some display issues, but it's readable and comprehensible).

If you have any remarks, feel free to discuss.

apolikamixitos included the following code: https://github.com/adobe/brackets/pull/2323/commits

core-ai-bot commented 3 years ago

Comment by njx Wednesday Dec 12, 2012 at 01:23 GMT

Thanks for doing this! A couple of questions that would help us decide whether we should take this now:

core-ai-bot commented 3 years ago

Comment by apolikamixitos Wednesday Dec 12, 2012 at 13:55 GMT

The display issues are just for the LTR (not for RTL) if there is a combination of Arabic and Latin words.

Otherwise if the text has only Arabic words, it'll work fine with LTR, but after adding Latin words the sentence will be reversed and then we must use the RTL support.

Check out the screenshot i uploaded here, you'll see the differences.

RTL

core-ai-bot commented 3 years ago

Comment by njx Wednesday Dec 12, 2012 at 23:27 GMT

Ah, thanks. Just so I understand (since I don't really know anything about bidi) -- the Arabic portion should always be RTL even in LTR contexts, correct? Do you know of any other places in Brackets where this problem shows up?

core-ai-bot commented 3 years ago

Comment by apolikamixitos Thursday Dec 13, 2012 at 14:40 GMT

In general, yes.

Look at this snapshot i added.

by using the LTR context you can see the parts surrounded with green are correct, but it's not the case with the red ones, in this case the RTL context MUST be applied on them.

The green parts are also readable in the LTR context, but they don't represent the REAL portion of the Arabic language which is RTL.

ExRTL2Brackets

core-ai-bot commented 3 years ago

Comment by njx Wednesday Dec 19, 2012 at 22:20 GMT

Thanks for the feedback. I think we'll leave this open but unmerged for now; I filed #2406 on the issue you mentioned. Will discuss with the team as to what we want to do with this.

core-ai-bot commented 3 years ago

Comment by njx Thursday Dec 20, 2012 at 18:47 GMT

To@ryanstewart to drive whether we want to merge this in advance of fixing #2406 and determining other requirements for handling RTL/bidi.

core-ai-bot commented 3 years ago

Comment by ryanstewart Saturday Dec 22, 2012 at 02:05 GMT

I've found a fix for #2406 but I'm not totally sure how easy it is to implement. Browsers have an attribute, dir that can be applied to elements that will force them to display the text right-to-left. I've got a screenshot of it working below with chrome developer tools.

But a fix seems like it might be semi-complicated. The best thing to do might be to have a flag that will mark strings as mixed right-to-left and then when we create those elements create the dir attribute. But I haven't scoped out how much work that is.

And we do still have the problem that the UI isn't going to be right-to-left.@apolikamixitos if we fix the text issue but can't fix the UI issue for a few months, do you think that would be okay for Arabic users?

core-ai-bot commented 3 years ago

Comment by apolikamixitos Saturday Dec 22, 2012 at 11:43 GMT

I think it would be alright@ryanstewart , since most Arab web developers (i personaly know) don't use Arabic tools for their tasks.

I think it will be a great push for Arabic users, especially for web designers.

If you need any further information just let me know.

core-ai-bot commented 3 years ago

Comment by ryanstewart Monday Jan 14, 2013 at 21:07 GMT

@apolikamixitos would you be able to look at #2406 and see if you can code up a fix so that Brackets uses <html dir="ltr"> for RTL languages?

core-ai-bot commented 3 years ago

Comment by apolikamixitos Saturday Jan 19, 2013 at 21:48 GMT

@ryanstewart i've just checked out your request, and i took a look on #2535 as well, i think that CodeMirror v3 will support Arabic with the RTL support.

In the example above ( adobe/brackets/pull/2323#issuecomment-11289428 ) i used the 'dir' attribute on Chrome and it worked well.

I'll check out marijnh/CodeMirror/pull/1103 if it works, if it doesn't, then i'll try the 'dir' attribute.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Apr 16, 2013 at 21:18 GMT

@apolikamixitos we're reviewing our older pull requests and noticed that you haven't signed the CLA yet. Can you let us know when you sign? http://dev.brackets.io/brackets-contributor-license-agreement.html

core-ai-bot commented 3 years ago

Comment by njx Tuesday Apr 16, 2013 at 21:20 GMT

@apolikamixitos - sorry for leaving this around so long. We haven't had a chance to look into the RTL issues yet, so we've added it to the backlog: https://trello.com/c/AwlfnUSa. We're going to close your pull request for now, but would reopen it later once we get to looking at the RTL issues. Thanks!

core-ai-bot commented 3 years ago

Comment by atefBB Saturday Aug 12, 2017 at 06:19 GMT

@apolikamixitos what's the state of this PR?