search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Toolbar icons misaligned when extensions add icons #2227

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by peterflynn Tuesday Dec 11, 2012 at 00:54 GMT Originally opened as https://github.com/adobe/brackets/issues/2328

  1. Add the PhoneGap Build extension to Brackets
  2. Observe header 'toolbar' in upper-right

Result: lightning bolt icon is positioned too low.

Expected: lightning bolt icon's vertical position is same as when PGB is not installed.

@GarthDB, it looks like #2254 caused this. From what I gather, with the !importants and all, it was intended to be backwards-compatible with existing extensions -- so I'm filing the bug against us rather than against PGB.

core-ai-bot commented 2 years ago

Comment by GarthDB Thursday Dec 13, 2012 at 21:20 GMT

Should we encourage all the icons to be the same size? The lightning bolt is not square, so it messes with stuff.

core-ai-bot commented 2 years ago

Comment by peterflynn Saturday Dec 15, 2012 at 02:11 GMT

Are they all the same size vertically, at least? Consistent vertical alignment seems to be the most important thing...

core-ai-bot commented 2 years ago

Comment by GarthDB Saturday Dec 15, 2012 at 02:18 GMT

Currently the lighting is not.

On Friday, December 14, 2012, Peter Flynn wrote:

Are they all the same size vertically, at least? Consistent vertical alignment seems to be the most important thing...

— Reply to this email directly or view it on GitHubhttps://github.com/adobe/brackets/issues/2328#issuecomment-11398769.

core-ai-bot commented 2 years ago

Comment by njx Monday Dec 17, 2012 at 19:08 GMT

Reviewed.

core-ai-bot commented 2 years ago

Comment by GarthDB Thursday Dec 20, 2012 at 18:43 GMT

made a pull request that will close this - https://github.com/adobe/brackets/pull/2416

core-ai-bot commented 2 years ago

Comment by njx Thursday Dec 20, 2012 at 21:27 GMT

The Brackets lightning bolt is fixed, but the PGB icon will still need to be fixed in order to line up.@GarthDB is putting up a pull request in the PGB repo for that, but in the meantime we can move this bug out of sprint 18.

core-ai-bot commented 2 years ago

Comment by GarthDB Wednesday Jan 09, 2013 at 22:10 GMT

I tried putting together a pull request, but the way their sprite sheet is a bit too complicated to resize easily. I did submit the issue on their repo.