search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Prioritize platform-specific keybindings over generic bindings #2262

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jasonsanjose Monday Dec 17, 2012 at 20:13 GMT Originally opened as https://github.com/adobe/brackets/pull/2372

Fixes Joel's issue from this morning's standup

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/2372/commits

core-ai-bot commented 3 years ago

Comment by redmunds Monday Dec 17, 2012 at 21:53 GMT

Done with initial review.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Monday Dec 17, 2012 at 22:37 GMT

@redmunds ready to review again. I didn't add any validation of key bindings since it depends on usage. Clients may add key bindings at any time, in any order. It doesn't seem to make sense to do the validation work, at least in our current state.

core-ai-bot commented 3 years ago

Comment by redmunds Monday Dec 17, 2012 at 23:48 GMT

The validation I was asking about is whether a keybinding is for core Brackets code, or from an extension.

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Dec 18, 2012 at 18:43 GMT

There doesn't yet seem to be a reasonable way to determine if a shortcut is coming from an extension, so dropping that.

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Dec 18, 2012 at 18:57 GMT

Looks good. Merging.

@joelrbrandt This fixes the key binding bug you showed in the architecture meeting