search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] CSS Code Hinting for new CodeHintManager-API #2376

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by zoufahl Tuesday Jan 08, 2013 at 23:16 GMT Originally opened as https://github.com/adobe/brackets/pull/2492

This extension adds basic CSS Code Hinting for Brackets. (similar to HTML Code Hinting), but uses more keys to trigger the hinting.

It differentiates between primary (alphabet) and secondary (whitespace, (semi-)colon) trigger keys to distinguish whether hints should be selected initially or not.

Works in *.css files and style-blocks in html-files Does not work in inline-css yet, due to limited tokenizing.

zoufahl included the following code: https://github.com/adobe/brackets/pull/2492/commits

core-ai-bot commented 3 years ago

Comment by RaymondLim Tuesday Jan 08, 2013 at 23:49 GMT

@zoufahl Thanks for working on this!

You have a long list of commits in this pull request. Can you squash them into a single commit?

The easiest way to do it is to create a new branch off master, check it out, then "git merge --squash andrez/csscodehinting-v2", then submit a pull request off the new branch.

Let me know if you need help in squashing.

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Jan 09, 2013 at 00:00 GMT

The extension also need to be moved from the extensions/dev folder to the extensions/default folder. You can probably just close this pull request are create a new one with the files moved, and that will squash everything to a single commit.

core-ai-bot commented 3 years ago

Comment by RaymondLim Wednesday Jan 09, 2013 at 00:55 GMT

@zoufahl One more thing! Your CSS properties list in json file may not be accurate or complete. Can you also check against the following urls and update them? (eg. font-family is missing in there)

http://www.w3.org/TR/CSS/#indices

CSS 3 properties are chunked into several modules:

http://www.w3.org/TR/css3-ui/#property http://www.w3.org/TR/css3-2d-transforms/#property-index http://www.w3.org/TR/css3-transitions/#property-index http://www.w3.org/TR/css3-fonts/#property-index http://www.w3.org/TR/css3-text/#appendix-f-full-property-index http://www.w3.org/TR/css3-animations/#property-index http://www.w3.org/TR/css3-color/#property

core-ai-bot commented 3 years ago

Comment by zoufahl Wednesday Jan 09, 2013 at 11:04 GMT

@RaymondLim I noticed that too today, that the list is incomplete.

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Jan 09, 2013 at 16:04 GMT

@zoufahl ,

Thank you for this awesome contribution to Brackets! For this (updated) pull request, we will focus on the CSS Code Hinting mechanism. The CSS information will always be a moving target, so we will improve that in another pull request, and again as necessary. No need to worry about that at this time.

Thanks, Randy