search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Load extensions before loading project, then fire APP_READY. #2385

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jasonsanjose Wednesday Jan 09, 2013 at 22:35 GMT Originally opened as https://github.com/adobe/brackets/pull/2501

Fix for #1951

Change app initialization to load extensions first, then load the project and initialize the working set before firing the APP_READY event. Many thanks to@DennisKehrig.

While cleaning up the startup process, I opportunistically cleaned up a lot of startup code by deferring some initialization out of the module init (implicit and/or explicit) and into APP_READY and HTML_READY handlers as appropriate.

Unit, performance and extension tests are passing.

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/2501/commits

core-ai-bot commented 3 years ago

Comment by dangoor Thursday Jan 10, 2013 at 21:33 GMT

I didn't see anything amiss here. It looks like a nice refactoring. I haven't had a chance to exercise it beyond firing up Brackets and having it run. I'll play around with some more features later on, but it's looking good.

core-ai-bot commented 3 years ago

Comment by njx Thursday Jan 10, 2013 at 21:37 GMT

@dangoor -- fyi, it's better to make comments in the "Files" tab (instead of on individual commits) -- that way all the comments can be viewed in context in one place (and github will show the surrounding code in this "Discussion" tab as well). Kind of a weird workflow issue in github.

core-ai-bot commented 3 years ago

Comment by njx Thursday Jan 10, 2013 at 21:37 GMT

(oops, meant "it's better to make inline comments in the "Files" tab"--other general comments can just go in Discussion)

core-ai-bot commented 3 years ago

Comment by jasonsanjose Thursday Jan 10, 2013 at 23:27 GMT

Changes pushed. Ready for review@dangoor.

core-ai-bot commented 3 years ago

Comment by dangoor Friday Jan 11, 2013 at 01:50 GMT

@njx thanks for the tip. I made those comments and came back to the pull request page and was a bit puzzled as to why my comments didn't show up with the diffs as it has for others.

core-ai-bot commented 3 years ago

Comment by dangoor Friday Jan 11, 2013 at 02:05 GMT

Looks good to me, and I just tested out a number of features and everything is working fine. I'll merge.

core-ai-bot commented 3 years ago

Comment by njx Friday Jul 19, 2013 at 22:28 GMT

Removing "for release note" label from this old pull request.

core-ai-bot commented 3 years ago

Comment by njx Friday Jul 19, 2013 at 22:29 GMT

Hmm. Apparently I can't remove the label, even from the summary view. Oh well.