[CLOSED] Added Arabic translation

brackets-archive / bracketsIssues

Archive of issues in brackets.

0 stars 0 forks source link

[CLOSED] Added Arabic translation #2414

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by ghost Monday Jan 14, 2013 at 14:49 GMT Originally opened as https://github.com/adobe/brackets/pull/2535

Hello, After a few hours of work I've completed the brackets Arabic translation. Some words may be in English; Because, I've found it hard to translate to Arabic since I'm still learning it (I'm a pretty Advanced Student), So hopefully a native speaker could review my work and make changes but I think as of now most Arabic speakers would be able to understand and use brackets correctly. NOTE: The Arabic I used in this translation is called, Fushah Arabic; This is the proper and official type of Arabic that is spoken in Saudi Arabia. Thanks, @_C1D

ghost included the following code: https://github.com/adobe/brackets/pull/2535/commits

core-ai-bot commented 3 years ago

Comment by ghost Monday Jan 14, 2013 at 14:52 GMT

Hello, Sorry guys I just realized that some one else has created a translation over here: https://github.com/adobe/brackets/pull/2323. Please forgive me, I've closed this pull request. Thanks, @_C1D

core-ai-bot commented 3 years ago

Comment by ryanstewart Monday Jan 14, 2013 at 21:08 GMT

@C1D would you be able to look at #2406 and see if you can code up a fix so that Brackets uses <html dir="ltr"> for RTL languages? I also asked the contributor of the other translation to take alook.

core-ai-bot commented 3 years ago

Comment by ghost Tuesday Jan 15, 2013 at 10:35 GMT

Sure, I'll check it out and see what I can do.

core-ai-bot commented 3 years ago

Comment by ryanstewart Thursday Jan 17, 2013 at 22:30 GMT

Hey@C1D, it looks like this pull request on CodeMirror might do it for us - https://github.com/marijnh/CodeMirror/pull/1103`@`njx, do we pull in latest codemirror fixes when they come in?

core-ai-bot commented 3 years ago

Comment by njx Thursday Jan 17, 2013 at 22:42 GMT

@ryanstewart -- we will be doing that once we do the final CodeMirror v3 merge. However, I don't think that particular pull request is the key to our issues:

I believe CM v3 already supports RTL text--it just doesn't physically move the gutter/line numbers to the right while in RTL mode. Obviously that's something you'd want in addition, but it's a second-order issue compared to general RTL support.
Also, several of the issues that people have observed with Arabic have to do with other parts of the UI besides the editor (e.g. in the About dialog), so that CM pull request won't fix all our issues.

core-ai-bot commented 3 years ago

Comment by njx Thursday Jan 17, 2013 at 22:43 GMT

Actually, I take back my first point before--the added functionality from that CM pull request (when it lands) is probably significantly helpful in the editor. It looks like it's languished a bit though.