[CLOSED] Rename folder does not update jsTree completely

[core-ai-bot]

Issue by redmunds Tuesday Jan 15, 2013 at 17:14 GMT Originally opened as https://github.com/adobe/brackets/issues/2551

---

I noticed this while working on https://github.com/adobe/brackets/issues/2503. Renaming a folder does not update the file paths in Find in Files panel, but it's a problem in ProjectManager.js:

1. Put breakpoint in ProjectManager.js function renameItem() near beginning of function on this line:

    if (oldName === newName) {

1. Rename a folder in Brackets
2. Repeat step 2 as necessary

Results: newName is the same as oldName, and oldName is the name when Brackets session started. So, name change event is never sent for folders.

Notice that the new name is displayed the project tree.

[core-ai-bot]

Comment by pthiess Friday Jan 18, 2013 at 23:18 GMT

---

Medium priority, assigned to@redmunds

[core-ai-bot]

Comment by DennisKehrig Wednesday Feb 20, 2013 at 13:06 GMT

---

The problem is that the regular expression requires the string to end with the new name, but for folders there's a "/" there. As a result, the new name is not determined correctly. I will put a pull request later to fix this.

[core-ai-bot]

Comment by WebsiteDeveloper Wednesday Feb 20, 2013 at 13:13 GMT

---

@DennisKehrig i already submitted a pull adressing this issue

[core-ai-bot]

Comment by DennisKehrig Wednesday Feb 20, 2013 at 13:25 GMT

---

@WebsiteDeveloper Almost :) Please see my comment Edit: The URL was incorrect

[core-ai-bot]

Comment by DennisKehrig Wednesday Feb 20, 2013 at 13:39 GMT

---

@WebsiteDeveloper Sorry that I basically replaced your work, I didn't see your pull request before I encountered and fixed the bug myself, otherwise I would have tried your fix and reported back to you.

[core-ai-bot]

Comment by gruehle Tuesday Feb 26, 2013 at 17:53 GMT

---

FBNC,@redmunds

[core-ai-bot]

Comment by redmunds Tuesday Feb 26, 2013 at 18:56 GMT

---

Confirmed. Closing.