search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [cmv3] HTML Code Hints are not displayed on "<" key #2436

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by redmunds Tuesday Jan 15, 2013 at 21:02 GMT Originally opened as https://github.com/adobe/brackets/issues/2558

Typing "<" in an HTML file does not show code hints. Typing Ctrl-Space does not pop them up either.

If you type a char (e.g. "i") then press Ctrl-Space they are displayed.

core-ai-bot commented 3 years ago

Comment by gruehle Friday Jan 18, 2013 at 23:20 GMT

Reviewed

core-ai-bot commented 3 years ago

Comment by njx Friday Jan 25, 2013 at 00:49 GMT

To@RaymondLim. It looks like in CM v3, the HTML tokenizer flags an unclosed start tag as an error, which confuses HTMLUtils.getTagInfo(). Need to update it to deal with this case.

core-ai-bot commented 3 years ago

Comment by RaymondLim Friday Jan 25, 2013 at 05:02 GMT

Fixed in cmv3 branch. Also fixed a HTMLUtils test failure in collecting attributes from an invalid html tag.

core-ai-bot commented 3 years ago

Comment by njx Friday Jan 25, 2013 at 05:28 GMT

@RaymondLim -- we're doing pull requests for changes in the cmv3 branch (you just need to switch the base branch fo cmv3 when making the pull request). Please have someone familiar with the code review the changes in your commit (looks like it's baab037) just to make sure. Thanks!

core-ai-bot commented 3 years ago

Comment by RaymondLim Friday Jan 25, 2013 at 18:58 GMT

FBNC@redmunds

core-ai-bot commented 3 years ago

Comment by redmunds Friday Jan 25, 2013 at 19:09 GMT

I looked at the commit and it looks good. Confirmed that bug is fixed. Tested around it a bit and didn't find any other problems. Closing.