search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Basic font colors are too low contrast #2706

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by isonno Wednesday Feb 13, 2013 at 21:24 GMT Originally opened as https://github.com/adobe/brackets/issues/2861

This is similar to #2742, but the issue is not limited to Japanese. The default font coloring - gray on gray, or pastel on gray - is too low contrast for some developers. At a minimum, there needs to be some setting for improving the text contrast.

This is with Sprint 19

core-ai-bot commented 3 years ago

Comment by pthiess Thursday Feb 14, 2013 at 00:52 GMT

@GarthDB please review and feel fre to re-prioritize.

core-ai-bot commented 3 years ago

Comment by GarthDB Thursday Feb 14, 2013 at 00:56 GMT

@isonno are you referring to the comment color, or the base color, or both? Screenshot_2_13_13_4_55_PM

core-ai-bot commented 3 years ago

Comment by isonno Thursday Feb 14, 2013 at 22:09 GMT

The base color AND the background. The background should WHITE (FFFFFF), the main body text should be BLACK (000000), or equally saturated colors. Dimming the contrast (because some designer thought it looked hip?) is just crazy, and is literally going to give your users headaches. Why do people buy new Kindles to replace their old kindles? Because the screen contrast got better. Why are the default settings in Brackets like an eight year old Kindle? Look at XCode and VStudio. They've had a lot of experience with this.

core-ai-bot commented 3 years ago

Comment by TomMalbran Thursday Feb 14, 2013 at 22:19 GMT

I like that the background color is not white. Pure white can get too bright and can hurt the eyes watching it all day. So for coding is great that it isn't, and the contrast still looks good.

core-ai-bot commented 3 years ago

Comment by isonno Thursday Feb 14, 2013 at 22:27 GMT

You'll have user settings for this, yes?

core-ai-bot commented 3 years ago

Comment by GarthDB Thursday Feb 14, 2013 at 22:28 GMT

@Isonno Color, like all design, is subjective, at least in part. Trying to find one colorscheme that makes everyone happy will be impossible. What we need is a better way of creating, installing, and switching themes for the editor.

Until then you can tweak your local copy to be whatever you want.

The current decision was not based on being hip, but rather softening the contrast to be slightly easier on the eyes, like Tomás mentioned. 

That being said the comments are too subdued and we will be increasing the contrast. — Sent from Mailbox for iPhone

On Thu, Feb 14, 2013 at 2:19 PM, Tomás Malbrán notifications@github.com wrote:

I like that the background color is not white. Pure white can get too bright and can hurt the eyes watching it all day. So for coding is great that it isn't, and the contrast still looks good.

Reply to this email directly or view it on GitHub: https://github.com/adobe/brackets/issues/2861#issuecomment-13582029

core-ai-bot commented 3 years ago

Comment by isonno Thursday Feb 14, 2013 at 22:36 GMT

Can you point me to which files to tweak? brackets_theme_default.less looks like a strong candidate, but I couldn't immediately tell which parameter controlled the base font & background

core-ai-bot commented 3 years ago

Comment by njx Friday Feb 15, 2013 at 01:36 GMT

@isonno--yeah, it's not super clear. It looks like the background we use in the code editor (in brackets_codemirror_override.less) is@background-color-3, and the text color is@content-color; try tweaking those and let us know how it works for you. We definitely plan to make all this specifiable in preferences eventually.

Thanks for the feedback.

core-ai-bot commented 3 years ago

Comment by roman02 Monday Apr 21, 2014 at 08:04 GMT

I fully agree with@isonno — the low contrast is horrible to have. It's in many places in Brackets — in various dialogs. When I see this on websites, I disable the poor choices in colors using Firebug, but I can't in this editor.

core-ai-bot commented 3 years ago

Comment by connect-m Wednesday Jun 18, 2014 at 15:54 GMT

I agree with isonno. I would like to change some colors of type and faces in Brackets. I tried some Theme-Extensions but they are rarely bright in appearance. Most of them are dark themes which do not fit my needs. :(

core-ai-bot commented 3 years ago

Comment by toomanylogins Wednesday May 20, 2020 at 13:05 GMT

Has this been resolved. I have tried multiple themes try and get a decent level of contrast but the designers seem to be in control these days and it's all faded out. For those of us that are longsighted this is a very poor decision. It would be very useful just to have some basic options to change the colours of the fonts for each theme.

core-ai-bot commented 3 years ago

Comment by isonno Wednesday May 20, 2020 at 19:17 GMT

@toomanylogins Try Visual Studio Code, it's pretty well supplanted Brackets these days.

core-ai-bot commented 3 years ago

Comment by roman02 Friday Jun 19, 2020 at 03:27 GMT

VS Code is good, indeed.