search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Scroll position jiggles when closing Go to Definition (Quick Open) #2750

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Wednesday Feb 20, 2013 at 06:43 GMT Originally opened as https://github.com/adobe/brackets/issues/2908

  1. Open EditorManager
  2. Ctrl+T and type "doShow"
  3. Press Enter

Result: editor scrolls up about half a line and then immediately scrolls back down the same amount.

Oddly, this does not happen if you click on the item in the results list instead of hitting Enter...

Seems CMv3 related: repros in Sprint 20 build but not Sprint 19. Marking Medium & nominating for Sprint 21 since it's pretty noticeable (I hit it dozens of times a day).

core-ai-bot commented 3 years ago

Comment by njx Thursday Feb 21, 2013 at 01:54 GMT

Assigning to me for now.

core-ai-bot commented 3 years ago

Comment by pthiess Monday Feb 25, 2013 at 19:13 GMT

Reviewed, moved to Sprint 22.

core-ai-bot commented 3 years ago

Comment by njx Wednesday Mar 13, 2013 at 00:39 GMT

Interestingly, it doesn't happen in all cases. For example, if you start at the top of the document, then do a find definition for _showEditor, it never jiggles.

core-ai-bot commented 3 years ago

Comment by njx Wednesday Mar 13, 2013 at 00:51 GMT

Even more interestingly: it doesn't happen if you click on the search result instead of hitting enter.

core-ai-bot commented 3 years ago

Comment by njx Thursday Mar 14, 2013 at 01:01 GMT

Spent more time on this, and I'm still stumped. I've gone through and added console traces around all the places in CM that manage scroll position, and I can't find a substantial difference between the cases that jiggle and the cases that don't. It doesn't seem to be a timing issue--I can type as slow as I like and still see the behavior, and the order of scrolling operations when the modal bar closes is consistent.

core-ai-bot commented 3 years ago

Comment by njx Wednesday Mar 20, 2013 at 22:40 GMT

A hint that this might be related to #2909: in both this bug and #2909, the jiggle doesn't seem to happen if you have a permanent horizontal scrollbar visible (e.g. if you plug a mouse in on Mac). So if Marijn fixes the bug underlying #2909, it's possible (though maybe a long shot) that this might go away as well.

core-ai-bot commented 3 years ago

Comment by njx Thursday Mar 21, 2013 at 16:19 GMT

FBNC@peterflynn with latest CM.

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Mar 21, 2013 at 22:35 GMT

Confirmed. Sweet!