search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] FOR REVIEW ONLY: extensible code hint dialogs #2755

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by redmunds Wednesday Feb 20, 2013 at 16:40 GMT Originally opened as https://github.com/adobe/brackets/pull/2915

Prototype of proposed extensibility mechanism for adding dialogs to code hint menus for issue #2695.

redmunds included the following code: https://github.com/adobe/brackets/pull/2915/commits

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Feb 20, 2013 at 19:27 GMT

@joelrbrandt I updated my prototype to use a code hint provider with my own JSON data, instead of hacking JSON data of the CSSCodeHints extension.

But, this seems to eliminate the need for the CodeHintManager registerDialog/lookupDialog mechanism. This brings us back to where the EWF extension currently is, so maybe the status quo is good enough?

Actually, 1 improvement is putting the property in CSSProperties.json, so maybe that's worth using.

Any other ideas on ways to improve this?

core-ai-bot commented 3 years ago

Comment by redmunds Thursday May 16, 2013 at 23:18 GMT

@joelrbrandt What are your thoughts on this? Is there any reason to keep this branch alive?

core-ai-bot commented 3 years ago

Comment by joelrbrandt Thursday May 23, 2013 at 10:59 GMT

@redmunds Ugh, sorry, I've been incredibly irresponsible about this. The good news is that there's substantially more responsible people than me on the Edge Code team that have sort of taken up this cause.

@couzteau@iwehrman -- Randy was nice enough to start this branch a long time ago as a way to address the difficulties with augmenting the code hint list (with things like the "Browse Edge Web Fonts..." link. I think you've come up with a work around that@ryanstewart is happy with. Do you have thoughts on this branch?

Thanks again for your help on this. Sorry I've been so unresponsive.

core-ai-bot commented 3 years ago

Comment by iwehrman Tuesday Jun 04, 2013 at 18:12 GMT

The Edge Code team decided that adding stubs outside of the hint list wasn't a good fit for our particular problem. Even with a better code hint list implementation, we anticipated keyboard accessibility problems without an obvious (and discoverable) solution. Instead we chose to add the stub to the menu directly as a first-class menu item. So there isn't a need from our end to keep this pull open any longer.

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Jun 04, 2013 at 19:45 GMT

Agreed. We can revisit this if any useful patterns emerge. Closing.