search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Brackets hits a breakpoint on every reload with Dev Tools open #2770

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Friday Feb 22, 2013 at 01:33 GMT Originally opened as https://github.com/adobe/brackets/issues/2932

  1. Launch Brackets
  2. Open the Developer Tools
  3. Click the footer icon that looks like a stopsign containing a "pause" icon until it turns purple (the setting for "pause on uncaught exceptions")
  4. Reload Brackets

Result: Brackets freezes in the middle of reloading. You have to go to the Developer Tools and click the resume button.

Console shows this:

Uncaught SyntaxError: Unexpected end of input     appshell:430
appshell.app.getPendingFilesToOpen                appshell:430

I originally started noticing this with the CEF update, but I'm still seeing it now that it's backed out... so perhaps this is related to the Node stuff landing? @joelrbrandt does "getPendingFilesToOpen()" ring a bell at all?

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Feb 22, 2013 at 01:33 GMT

Nominating as Medium for this sprint since it adds a productivity drag on the dev experience...

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Feb 22, 2013 at 01:39 GMT

Oops, sorry Joel -- looks like this is related to@gruehle's adobe/brackets-shell#190.

It looks like the exception is being thrown by the JSON.parse() in appshell_extensions.js's getPendingFilesToOpen(). I notice parse() throws such an error when handed an empty string...

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Feb 26, 2013 at 19:48 GMT

FBNC@peterflynn. Waiting for next shell build.

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Feb 27, 2013 at 23:48 GMT

Confirmed fixed. Thank goodness! That was getting really annoying for debugging :-(