search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Polish Language #3040

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by rafalborowski Sunday Mar 24, 2013 at 09:54 GMT Originally opened as https://github.com/adobe/brackets/pull/3235

Only the core files (strings.js) but "Getting Started" is comming very soon. Tested it out for a fed days and it seems fine.

With an IELTS passed and Polish as my native language I feel pretty confident about this en->pl translation but someone should of course check it before merging.

rafalborowski included the following code: https://github.com/adobe/brackets/pull/3235/commits

core-ai-bot commented 3 years ago

Comment by WebsiteDeveloper Sunday Mar 24, 2013 at 10:04 GMT

@rafalborowski some of the new strings for sprint 22 are not included please merge with master and check the english strings.js for the missing strings.

core-ai-bot commented 3 years ago

Comment by rafalborowski Sunday Mar 24, 2013 at 11:06 GMT

Yes it was done using sprint 21. I will make all the necessary changes ASAP. When is the Sprint 22 ETA?

core-ai-bot commented 3 years ago

Comment by rafalborowski Sunday Mar 24, 2013 at 12:03 GMT

@WebsiteDeveloper Done. Will now move to translate "Getting Started" but since it's Sunday noon here in Poland I might schedule that for tomorrow.

core-ai-bot commented 3 years ago

Comment by rafalborowski Sunday Mar 24, 2013 at 15:02 GMT

Oh well... took a chunk of my Sunday afternoon for the greater good :) Getting Started translated. Would love to see this included in Sprint 22.

Should I also add Polish language to the translation list in README.md file in the nls folder?

core-ai-bot commented 3 years ago

Comment by WebsiteDeveloper Sunday Mar 24, 2013 at 15:52 GMT

i would certainly add it

core-ai-bot commented 3 years ago

Comment by jbalsas Sunday Mar 24, 2013 at 15:52 GMT

@rafalborowski Sadly, Sprint 22 closed last Friday. Sprints are only around two and a half weeks though, so this has a great chance of making it into the next one in no time ;)

To expedite things a little, as@WebsiteDeveloper indicated in the other issue, you'd need to find some polish native speaker to do a peer review aside from the sanity check that we may do.

core-ai-bot commented 3 years ago

Comment by jbalsas Sunday Mar 24, 2013 at 17:42 GMT

Reviewing...

@jasonsanjose I know you usually do these. I thought I could save you some time for next sprint by taking this one. Please, feel free to jump in any time.

core-ai-bot commented 3 years ago

Comment by jbalsas Monday Mar 25, 2013 at 00:04 GMT

@rafalborowski Done with initial review! Thanks a lot for taking the time to get this translated and start playing and hacking with Brackets ;)

Thanks for your patience and understanding with all my comments. Remember that after addressing all these issues we'll still need some native speaker to do a peer review before merging.

core-ai-bot commented 3 years ago

Comment by rafalborowski Monday Mar 25, 2013 at 09:44 GMT

@jbalsas Thank you so much for taking your precious time and reviewing this. I have to say that I couldn't believe how many typos I've made :/ Sorry for that. Indeed it is time for my glasses to get fixed.

I've got it all fixed and added a screenshot of polish version as you suggested. The only thing is it is from Windows not Mac (as other screenshots) but since 99.9% of population here in Poland uses Windows PCs not Macs I think it would be actually a good thing.

One more thing about the review from a native speaker - I actually don't know if I can find someone to do that. Do we have any native polish devs here working on Brackets to jump on it?

core-ai-bot commented 3 years ago

Comment by jbalsas Monday Mar 25, 2013 at 20:05 GMT

@rafalborowski Thanks for all the changes! It's looking quite good ;)

I'll be posting on the dev list to see if we have someone there that can jump in.

I still have some concerns regarding the screenshot. It's actually way bigger than the other ones (though this may not be an issue) and it seems it has some sharp corners and missing shadows. About those windows numbers... wow... just wow! I could also agree that it could be goog to have this one taken in windows, but I'll bring in the big guns for this ;)@GarthDB@jasonsanjose What should we do with the screenshot here?

core-ai-bot commented 3 years ago

Comment by jbalsas Friday Mar 29, 2013 at 16:42 GMT

@rafalborowski Radek stepped up on the mailing list and offered to do a review of your translation, so we're closer to getting this settled. In the meantime, I remembered that we'll need you to sign our CLA before we can accept your contributions. http://dev.brackets.io/brackets-contributor-license-agreement.html. You'll only need to do this once, thanks! ;)

core-ai-bot commented 3 years ago

Comment by rafalborowski Friday Mar 29, 2013 at 18:28 GMT

I've already merged Radeks review few days ago (there wasn't many issues and he actualy said that the quality of translation was really good) but just didn't had time to finish everything. I will jump on it the first thing tomorrow. As for the CLA I've already did that like a week ago.

core-ai-bot commented 3 years ago

Comment by jbalsas Friday Mar 29, 2013 at 18:37 GMT

Oh, great then! (It would be nice if he could just leave a comment here or in the mailing list, just for posterity ;)).

About the CLA, I've checked again and it doesn't seem to be registered for the user 'rafalborowski'. Could you check or try again just to be sure?

@adrocknaphobia Are we aware of any issues regarding the CLA check utility?

core-ai-bot commented 3 years ago

Comment by rafalborowski Friday Mar 29, 2013 at 21:06 GMT

I've filled the CLA again

core-ai-bot commented 3 years ago

Comment by jbalsas Friday Mar 29, 2013 at 22:24 GMT

@rafalborowski There you are now! Since Radek already gave you the ok, I'm going to go ahead and merge this (I'll file a separate issue to see how we want to deal with the images in the Getting Started section).

Thanks a lot for working on this!