brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fix Live Dev unit tests due to HTMLDocument refactoring #3084

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by redmunds Thursday Mar 28, 2013 at 21:14 GMT Originally opened as https://github.com/adobe/brackets/pull/3281


This was introduced with my recent refactoring of HTMLDocument. Not sure why this only broke on Mac. Until that change, HTMLDocument was only ever created when experimental code was on, and that code hasn't been exercised very much.

Not sure why, but CSSAgent includes containing HTMLDocument in list returned from getStyleSheetURLs(). This could be useful for collecting embedded style sheets, but we do not want to add HTMLDocument to _relatedDocuments list, so filter it out.

Actual crash was coming from HTMLDocument being created with undefined editor. I fixed that particular code path, but also added bullet-proffing to HTMLDocument in case that ever happens in some other code path.


redmunds included the following code: https://github.com/adobe/brackets/pull/3281/commits

core-ai-bot commented 3 years ago

Comment by gruehle Friday Mar 29, 2013 at 16:28 GMT


Looks good. Merging.