search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Another two straightforward refactoring tasks for Language support #3104

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by WebsiteDeveloper Sunday Mar 31, 2013 at 08:55 GMT Originally opened as https://github.com/adobe/brackets/pull/3301

@DennisKehrig i completed two other straightforward refactoring tasks one concerning the QuickEdit feature and the other the CSSInlineEditor

WebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/3301/commits

core-ai-bot commented 3 years ago

Comment by DennisKehrig Sunday Mar 31, 2013 at 09:14 GMT

@WebsiteDeveloper Wonderful, I'm excited! :)

Two extensions also use the QuickOpen API:

If you want to, you could submit pull requests to both that can be merged shortly after merging this. Or add backwards compatibility (and a warning) by safely converting pluginDef.fileTypes to pluginDef.languageIds by mapping the file types to language IDs, I will then open issues in the extensions' repositories and the author can get to them whenever he feels like.

@peterflynn These are your extensions, any comments?

core-ai-bot commented 3 years ago

Comment by WebsiteDeveloper Sunday Mar 31, 2013 at 09:31 GMT

@DennisKehrig i added the backwards compatibility code.

core-ai-bot commented 3 years ago

Comment by DennisKehrig Sunday Mar 31, 2013 at 09:38 GMT

That was quick, thanks! I'll try to keep up :)

core-ai-bot commented 3 years ago

Comment by DennisKehrig Sunday Mar 31, 2013 at 09:48 GMT

Sorry for commenting on the commits directly, this makes it confusing to read here.

core-ai-bot commented 3 years ago

Comment by DennisKehrig Sunday Mar 31, 2013 at 09:52 GMT

Done with my first review!

core-ai-bot commented 3 years ago

Comment by WebsiteDeveloper Sunday Mar 31, 2013 at 10:10 GMT

@DennisKehrig changes pushed

core-ai-bot commented 3 years ago

Comment by DennisKehrig Sunday Mar 31, 2013 at 10:32 GMT

Looking good, merging!

core-ai-bot commented 3 years ago

Comment by DennisKehrig Sunday Mar 31, 2013 at 10:34 GMT

@WebsiteDeveloper That was an awesome session, thank you very much!