Open core-ai-bot opened 3 years ago
Comment by redmunds Friday Apr 19, 2013 at 02:52 GMT
@
dangoor Since you're reviewing the new JavaScript Code Hint code, can you comment on whether this pull request is obsolete?
Comment by dangoor Friday Apr 19, 2013 at 13:59 GMT
@
redmunds thanks for letting me know. I actually had it on my todo list to take a look at this once the tern integration had landed.
I may not get to this today, though.@
eztierney could take a look as well, if he has cycles.
Comment by dangoor Monday Apr 22, 2013 at 13:53 GMT
This pull request appears to still be valid. It doesn't merge automatically, but the changes are simple and still seem relevant.
@
eztierney do you see any problem with these changes?
Comment by eztierney Monday Apr 22, 2013 at 14:06 GMT
@
dangoor looks good to me - I don't see any problems with this change
Issue by iwehrman Monday Apr 08, 2013 at 20:35 GMT Originally opened as https://github.com/adobe/brackets/pull/3375
I don't know how these
triggerHandler
calls got leaked into this branch, but git blame implicates me. They serve no purpose here and should be removed.iwehrman included the following code: https://github.com/adobe/brackets/pull/3375/commits