search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Topcoat toolbar #3176

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Tuesday Apr 09, 2013 at 07:54 GMT Originally opened as https://github.com/adobe/brackets/pull/3381

This transforms the existing "#main-toolbar" structure into a vertical sidebar and renames the old white toolbar to "#titlebar." The titlebar above the editor is only visible when inBrowser=true.

ModalBar, which used to be inserted inside the top toolbar, is now inserted as a sibling to it so that it can be used even when the top toolbar is hidden.

Note: the CSS changes are based on Garth's topcoat branch.

peterflynn included the following code: https://github.com/adobe/brackets/pull/3381/commits

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Apr 09, 2013 at 07:54 GMT

@redmunds ready for review. I'll be doing performance testing on this tomorrow.

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Apr 09, 2013 at 16:42 GMT

The first thing I notice is that Hide/Show sidebar is broken:

  1. View > Hide Sidebar does not resize editor properly. Doesn't matter if a file is open or not. Causes large unpainted block on right.
  2. Continuing in state from 1, if you execute Find in Files, the editor gets resized. Then View > Show Sidebar shows same problem as above.
core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Apr 09, 2013 at 17:33 GMT

Crap, that feels like a webkit bug... the behavior is very inconsistent: every few times I try this it doesn't repro at all. It usually fixes itself as soon as I so much as click in the editor or scroll it. Sometimes after that hide/show panel starts working perfectly (for a while)... other times the new, wider editor size sticks and you start seeing the bug in reverse. And the editor's size isn't controlled programmatically -- it's a block element that in theory should automatically fill its parent width all the time.

I do have an idea for a slightly different CSS layout technique that may sidestep the issue... but this is definitely a little scary.

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Apr 09, 2013 at 20:07 GMT

Weird that this didn't happen with previous layout. The EditorManager.resizeEditor() method currently only handles height, so maybe it can be updated to also update width?

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Apr 09, 2013 at 20:34 GMT

@redmunds: Can you try out the pflynn/topboat-toolbar-altlayout branch and see if the layout bugs are gone? It fixes it for me, but I know this was slightly intermittent so double-checking would be good.

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Apr 09, 2013 at 21:22 GMT

Done with initial review.

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Apr 09, 2013 at 21:41 GMT

The layout in pflynn/topboat-toolbar-altlyout branch looks good. I tested on Mac 10.8 and Win7, with/without:

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Apr 09, 2013 at 23:13 GMT

@redmunds: changes pushed. NJ is also going to push a tiny fix for a clipping issue in the bottom panels, so please wait for that before merging.

core-ai-bot commented 3 years ago

Comment by njx Tuesday Apr 09, 2013 at 23:53 GMT

I just pushed my fix.

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Apr 10, 2013 at 00:11 GMT

@redmunds Just pushed a fix for your one last comment in main-view.html (fixing stale "right-hand content" terminology)

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Apr 10, 2013 at 00:46 GMT

Looks good. Merging.