search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] If package.json does not specify "files" property, then extension manager installs all the files from the extension url. #3221

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by RaymondLim Friday Apr 12, 2013 at 22:52 GMT Originally opened as https://github.com/adobe/brackets/issues/3431

  1. Select File > Install Extension...
  2. Provide an extension url that has a package.json but no "files" property specified in the json file.

Result: All files available in the specified url are installed into extensions/user folder including .gitignore and package.json.

Expected: Should exclude package.json and all files with dot prefix.

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Apr 12, 2013 at 23:21 GMT

I think we have to keep package.json because it includes metadata we'll need at runtime (for showing the extension management UI, for determining if a Brackets update makes any extensions incompatible, etc.).

Not sure if it's worth doing anything special to exclude a few common but small size dotfiles, given that extension authors can explicitly exclude them if they really care...

core-ai-bot commented 3 years ago

Comment by njx Thursday Apr 18, 2013 at 20:55 GMT

Reviewed. Marking low priority to@dangoor to think about whether we want to do anything about this, or just close it as "as designed".

core-ai-bot commented 3 years ago

Comment by dangoor Friday Apr 19, 2013 at 01:23 GMT

Yeah, I'd say this is "as designed". Files should be excluded before they wind up in the zip file (and this is something we'll eventually have tooling to help with).

I believe that excluding at packaging time is consistent with npm's behavior.