[CLOSED] Hook up inline CSS display

core-ai-bot commented 3 years ago

Issue by gruehle Wednesday Feb 29, 2012 at 19:46 GMT Originally opened as https://github.com/adobe/brackets/pull/336

This pull request hooks up all the various pieces for inline display of CSS rules.

When viewing an HTML file, pressing Cmd/Ctrl+E does the following:

checks to see if the selection is an insertion point
calls CodeHintUtils to get the tag/attribute at the insertion point
if the insertion point is in a tag name, use the tag name as the selector name
if the insertion point is in an id attribute value, use "#" + the value as the selector name
if the insertion point is in a class attribute value, use the word containing the insertion point as the class name, and prepend "." for the selector name

If the selector can be found within a .css file in your project, it will be displayed in an inline view.

To close an inline editor, set the insertion point anywhere inside the inline editor and press Cmd/Ctrl+E.

gruehle included the following code: https://github.com/adobe/brackets/pull/336/commits

core-ai-bot commented 3 years ago

Comment by chrisbank Wednesday Feb 29, 2012 at 19:48 GMT

reviewing

core-ai-bot commented 3 years ago

Comment by chrisbank Wednesday Feb 29, 2012 at 21:32 GMT

Codewise, I just have that one comment to make it easier to see how everything balances there. Just quickly testing, there are lots of bugs, but I think it's better to merge into master and let everyone test.

core-ai-bot commented 3 years ago

Comment by chrisbank Wednesday Feb 29, 2012 at 22:16 GMT

looks good, merging

brackets-archive / bracketsIssues

[CLOSED] Hook up inline CSS display #334