search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Special handling of _ names #3367

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by dangoor Wednesday Apr 24, 2013 at 14:35 GMT Originally opened as https://github.com/adobe/brackets/issues/3589

If you've got the Brackets source open and you write the following code (with the cursor where the "|" is):


var StringMatch = require("utils/StringMatch");
StringMatch.|

The completions that you get all begin with "_" and are, by convention, private.

I'm thinking that we should either sort them to the bottom or filter them out entirely. My inclination is sort them to the bottom, but I wanted to see what others think.

core-ai-bot commented 3 years ago

Comment by dloverin Wednesday Apr 24, 2013 at 15:34 GMT

Sorting them to the bottom is probably ok but I wouldn't want to filter them out. Other developers may allow functions with "_" to be used.

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Apr 24, 2013 at 18:02 GMT

And certainly if you type an "_" prefix they should bubble to the top.

core-ai-bot commented 3 years ago

Comment by njx Thursday May 02, 2013 at 20:35 GMT

Reviewed. To@dangoor, nominating for sprint 25--Kevin, please work with the LCVM folks as needed.

core-ai-bot commented 3 years ago

Comment by njx Tuesday May 14, 2013 at 22:50 GMT

Fixed by filer. Closing.