search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Don't install system extensions #3504

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by iwehrman Tuesday May 07, 2013 at 23:29 GMT Originally opened as https://github.com/adobe/brackets/pull/3744

The extension manager currently refuses to install extensions that are already installed the user's extension directory, but will happily install extensions that already exist in the system default extension directory. This can cause problems with extensions like Edge Web Fonts that are freely distributed online, but which are installed by default in Edge Code. This pull request adds an additional required option, systemDirectory, to the install command in the ExtensionManagerDomain that is used to avoid conflicts in the same way as the destinationDirectory parameter.

iwehrman included the following code: https://github.com/adobe/brackets/pull/3744/commits

core-ai-bot commented 3 years ago

Comment by RaymondLim Wednesday May 08, 2013 at 22:59 GMT

Done with initial review. Just one minor comment.

core-ai-bot commented 3 years ago

Comment by iwehrman Wednesday May 08, 2013 at 23:25 GMT

Comment addressed.

core-ai-bot commented 3 years ago

Comment by RaymondLim Wednesday May 08, 2013 at 23:28 GMT

Great! Merging.

core-ai-bot commented 3 years ago

Comment by njx Saturday May 11, 2013 at 02:40 GMT

FYI, there are some unit tests for these node modules that don't run in our standard test runner (yet), but run using jasmine-node--just install jasmine-node, cd into the module folder, then run jasmine-node spec. I'll go ahead and fix up those unit tests to handle this change.

@dangoor -- I remember that you looked into trying to get those tests to run as part of our test suite, but it sounds like it was hard :) I wonder if there's some better way to let people know about them at least.

core-ai-bot commented 3 years ago

Comment by dangoor Saturday May 11, 2013 at 03:26 GMT

@njx it should be fairly easy to get those tests running via Travis. I just haven't gotten around to it.

I have a bug assigned to me that is extension installation-related. If you'd like, you can leave the tests broken for now and I'll fix them when I hit that bug next week.

core-ai-bot commented 3 years ago

Comment by njx Saturday May 11, 2013 at 05:02 GMT

I already fixed it locally since I'm adding the uninstall functionality on the node side and wanted the tests to pass :) It'll go in with the extension listing stuff.