search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fix async issues in StaticServer unit tests #3585

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jasonsanjose Tuesday May 14, 2013 at 21:58 GMT Originally opened as https://github.com/adobe/brackets/pull/3829

Fix for #3645

Change StaticServer unit tests to share the NodeConnection Deferred to detect connection. Cleanup logging event handlers.

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/3829/commits

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday May 14, 2013 at 21:59 GMT

Assigned to@RaymondLim

core-ai-bot commented 3 years ago

Comment by RaymondLim Tuesday May 14, 2013 at 22:31 GMT

I'm still getting one test failure every other run with your changes. The failure is on line 388 expect(logs.length).toBe(1); where logs.length is zero.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday May 14, 2013 at 23:38 GMT

@RaymondLim ready to review. I couldn't reproduce the issue locally, but I have a hunch about what could cause the symptom you're seeing.

core-ai-bot commented 3 years ago

Comment by RaymondLim Tuesday May 14, 2013 at 23:51 GMT

Looks good. Merging.