[CLOSED] Use Tern jump-to-definition search for quickeditt

brackets-archive / bracketsIssues

Archive of issues in brackets.

0 stars 0 forks source link

[CLOSED] Use Tern jump-to-definition search for quickeditt #3596

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jeffkenton Wednesday May 15, 2013 at 21:56 GMT Originally opened as https://github.com/adobe/brackets/pull/3847

Current changes:

Use tern's jump-to-definition search for QuickEdit.
Change jump-to-definition to just select function name and place cursor at the end of the name to match what other editors do.

Future plans:

support finding var definitions in QuickEdit.
don't fall back to old QuickEdit search when tern knows a symbol is a builtin.
get tern to provide whole function extent, including function body and JSDoc style comments, if possible.

Note that the futures depend on improvements in tern.

jeffkenton included the following code: https://github.com/adobe/brackets/pull/3847/commits

core-ai-bot commented 3 years ago

Comment by njx Thursday May 16, 2013 at 21:24 GMT

Reviewing.

core-ai-bot commented 3 years ago

Comment by njx Thursday May 16, 2013 at 21:56 GMT

Review complete. It might be worth sending an email out to the team to discuss the "jump-to-definition-provider" issue...what I'm suggesting might be overkill, but I do feel like the approach in this pull request is a little too hacky. Maybe there's some better middle ground that I haven't thought of.

core-ai-bot commented 3 years ago

Comment by njx Friday May 17, 2013 at 17:59 GMT

Updates look fine. We can merge once the cross-dependency is addressed (either way)--also, looks like this needs a merge with master.

core-ai-bot commented 3 years ago

Comment by njx Friday May 17, 2013 at 18:00 GMT

Oops, I meant that it looks like there's a Travis failure, but it's not related to your code (@dangoor, it looks like a failure in the node package installation tests). Let's see if it fails again next time you push.

core-ai-bot commented 3 years ago

Comment by jeffkenton Friday May 17, 2013 at 19:25 GMT

I've pushed everything that I have seen requested. Let me know if I missed anything. Thanks.

core-ai-bot commented 3 years ago

Comment by njx Friday May 17, 2013 at 20:49 GMT

Looks good--just one last case I caught.

core-ai-bot commented 3 years ago

Comment by jeffkenton Monday May 20, 2013 at 12:00 GMT

We could check if "functions" is empty. Do you want to fall back to the other search in that case? I'm not sure if that would be worthwhile or not.

core-ai-bot commented 3 years ago

Comment by jeffkenton Monday May 20, 2013 at 12:24 GMT

Pushed the requested change -- now checking for empty "functions".

core-ai-bot commented 3 years ago

Comment by njx Monday May 20, 2013 at 16:15 GMT

Looks good, thanks. Merging