Open core-ai-bot opened 3 years ago
Comment by redmunds Thursday May 16, 2013 at 19:09 GMT
I was following the recipe you mentioned in #3792 for Dennis` problem (but was using smoke tests page) and ran into a lot of exceptions (on Win7).
Then I see this in the console:
Uncaught TypeError: Object function (searchedElement) {
var i = this.indexOf(searchedElement);
if (i !== -1) {
this.splice(i, 1);
}
} has no method 'clear' /C:/Users/redmunds/github/brackets-shell/Release/dev/src/LiveDevelopment/Documents/CSSDocument.js:201
More exceptions switching back to index.html or stopping Live Dev:
Uncaught TypeError: Object function (searchedElement) {
var i = this.indexOf(searchedElement);
if (i !== -1) {
this.splice(i, 1);
}
} has no method 'clear' /C:/Users/redmunds/github/brackets-shell/Release/dev/src/LiveDevelopment/Documents/CSSDocument.js:201
2
Document ref count has fallen below zero! /C:/Users/redmunds/github/brackets-shell/Release/dev/src/document/DocumentManager.js:677
Uncaught TypeError: Object function (searchedElement) {
var i = this.indexOf(searchedElement);
if (i !== -1) {
this.splice(i, 1);
}
} has no method 'clear' /C:/Users/redmunds/github/brackets-shell/Release/dev/src/LiveDevelopment/Documents/CSSDocument.js:201
Comment by jasonsanjose Thursday May 16, 2013 at 21:08 GMT
Thanks for the review. Taking a look at those errors and also a unit test failure that I missed.
Comment by jasonsanjose Monday May 20, 2013 at 22:18 GMT
Closing this pull and will reopen a new one that just addresses the two bugs. Here I've gone off on a tangent trying to confirm I hadn't introduced new unit test failures (see #3343), but those failures are far more difficult to fix than I anticipated.
Issue by jasonsanjose Thursday May 16, 2013 at 17:37 GMT Originally opened as https://github.com/adobe/brackets/pull/3852
3761 I found 2 issues here:
Inspected frame has gone
. This was due to ourkeepAlive
RemoteAgent
function call trying to call to a page(frame?) that no longer exists. I've updatedRemoteAgent
to stop thekeepAlive
timer when a new page loads.Inspector.connect()
where the inspector may get a disconnect event in the middle of the connection process. This caused an error dialog to appearUnable to load live development page
. I've changedconnect()
to wait for a newdisconnect()
promise to complete.3792 After switching the current live document, remove all HTTP request filters.
jasonsanjose included the following code: https://github.com/adobe/brackets/pull/3852/commits