brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fix live preview refresh issues #3601

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jasonsanjose Thursday May 16, 2013 at 17:37 GMT Originally opened as https://github.com/adobe/brackets/pull/3852


3761 I found 2 issues here:


jasonsanjose included the following code: https://github.com/adobe/brackets/pull/3852/commits

core-ai-bot commented 3 years ago

Comment by redmunds Thursday May 16, 2013 at 19:09 GMT


I was following the recipe you mentioned in #3792 for Dennis` problem (but was using smoke tests page) and ran into a lot of exceptions (on Win7).

  1. Open smokes index.html
  2. Start live preview
  3. Open desktop.css

Then I see this in the console:

Uncaught TypeError: Object function (searchedElement) {
        var i = this.indexOf(searchedElement);
        if (i !== -1) {
            this.splice(i, 1);
        }
    } has no method 'clear' /C:/Users/redmunds/github/brackets-shell/Release/dev/src/LiveDevelopment/Documents/CSSDocument.js:201

More exceptions switching back to index.html or stopping Live Dev:

Uncaught TypeError: Object function (searchedElement) {
        var i = this.indexOf(searchedElement);
        if (i !== -1) {
            this.splice(i, 1);
        }
    } has no method 'clear' /C:/Users/redmunds/github/brackets-shell/Release/dev/src/LiveDevelopment/Documents/CSSDocument.js:201
2
Document ref count has fallen below zero! /C:/Users/redmunds/github/brackets-shell/Release/dev/src/document/DocumentManager.js:677
Uncaught TypeError: Object function (searchedElement) {
        var i = this.indexOf(searchedElement);
        if (i !== -1) {
            this.splice(i, 1);
        }
    } has no method 'clear' /C:/Users/redmunds/github/brackets-shell/Release/dev/src/LiveDevelopment/Documents/CSSDocument.js:201
core-ai-bot commented 3 years ago

Comment by redmunds Thursday May 16, 2013 at 19:13 GMT


Done with initial review.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Thursday May 16, 2013 at 21:08 GMT


Thanks for the review. Taking a look at those errors and also a unit test failure that I missed.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Monday May 20, 2013 at 22:18 GMT


Closing this pull and will reopen a new one that just addresses the two bugs. Here I've gone off on a tangent trying to confirm I hadn't introduced new unit test failures (see #3343), but those failures are far more difficult to fix than I anticipated.