search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] QuickEdit: don't fallback to old search for known built-ins #3629

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jeffkenton Friday May 17, 2013 at 19:39 GMT Originally opened as https://github.com/adobe/brackets/issues/3886

In the QuickEdit search we currently use Tern's jump-to-definition search. If it doesn't find anything we fall back to the old QuickEdit regular expression search.

We shouldn't use the fallback if Tern knows the function name is a built-in that we don't have source for. Right now the fallback search finds user functions with the same name even though Tern knows this is wrong.

core-ai-bot commented 3 years ago

Comment by peterflynn Friday May 17, 2013 at 22:57 GMT

Could this lead to false negatives in some cases? E.g. if the user has overridden toString(), and then invokes QuickEdit on foo.toString() when Tern isn't sure what type foo is... would that cause us to not fallback, even though falling back would produce useful results?

core-ai-bot commented 3 years ago

Comment by pthiess Monday May 20, 2013 at 18:27 GMT

Reviewed - from our perspective a very low prio - we would suggest not to fix if it would create false positives.@dloverin

core-ai-bot commented 3 years ago

Comment by pfarland Tuesday Jun 18, 2013 at 15:25 GMT

Retiring this issue.