Open core-ai-bot opened 3 years ago
Comment by jasonsanjose Monday May 20, 2013 at 22:23 GMT
@
redmunds ready to review again. I wasn't able to produce those console errors you saw from #3852. Could that be coming from an extension? The console log you pasted contains code that I couldn't find in Brackets core at all.
Comment by redmunds Monday May 20, 2013 at 23:53 GMT
This looks good. I cannot reproduce the exceptions, so not sure where they were coming from. Travis build failed, so I'll merge when that's resolved.
Comment by jasonsanjose Tuesday May 21, 2013 at 03:01 GMT
Hmm.@
dangoor mentioned spurious jasmine-node errors earlier today. I can't reproduce these on my mac. Kevin, do you see any issues here? I think it's ok to merge.
Issue by jasonsanjose Monday May 20, 2013 at 22:19 GMT Originally opened as https://github.com/adobe/brackets/pull/3928
Replaces original pull #3852
3761 I found 2 issues here:
Inspected frame has gone
. This was due to ourkeepAlive
RemoteAgent
function call trying to call to a page(frame?) that no longer exists. I've updatedRemoteAgent
to stop thekeepAlive
timer when a new page loads.Inspector.connect()
where the inspector may get a disconnect event in the middle of the connection process. This caused an error dialog to appearUnable to load live development page
. I've changedconnect()
to wait for a newdisconnect()
promise to complete.3792 After switching the current live document, remove all HTTP request filters.
jasonsanjose included the following code: https://github.com/adobe/brackets/pull/3928/commits