search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [quick edit] in HTML file, quick editor shows function found from other file, not one in current file #3680

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jodyzhang Tuesday May 21, 2013 at 18:23 GMT Originally opened as https://github.com/adobe/brackets/issues/3942

  1. load brackets folder, open '/brackets/src/extensions/default/JavaScriptCodeHints/unittest-files/basic-test-files/index.html'
  2. put cursor on function fo<cursor>o, press command +E ->first it is slow, not showing up till try command+E couple times, then editor shows up, but it doesn't check function defined in current scope, instead it finds out quite lists(guess it searches, then returns list of suggestion).

However in this case, it should be simple detection, can we do better?

core-ai-bot commented 3 years ago

Comment by njx Thursday May 23, 2013 at 00:51 GMT

Looks like this only happens in HTML files. Edited description to reflect this.

core-ai-bot commented 3 years ago

Comment by njx Monday Jun 03, 2013 at 18:29 GMT

Reviewed. Marking low priority, to@eztierney.

core-ai-bot commented 3 years ago

Comment by eztierney Wednesday Jun 05, 2013 at 19:19 GMT

@jodyzhang I'm unable to reproduce this with the latest brackets - maybe it's been fixed?

core-ai-bot commented 3 years ago

Comment by jodyzhang Wednesday Jun 05, 2013 at 19:48 GMT

I can't get quick editor showing up on foo() in this case, I assume they change functionality?

core-ai-bot commented 3 years ago

Comment by eztierney Wednesday Jun 05, 2013 at 20:13 GMT

Oh, oops, I was doing jump-to-def.

Yeah, I don't see quick edit working anyways - I'd think it would since jump-to-def works.

core-ai-bot commented 3 years ago

Comment by jeffkenton Thursday Jun 06, 2013 at 12:26 GMT

Actually, the jump-to-definition part is working, but then it feeds the resulting filename to the old QuickEdit code in order to get the desired function location better than Tern does. The QuickEdit solution -- JSUtils.findMatchingFunctions -- strips out files that don't have .js extensions.

I'll fix it.

core-ai-bot commented 3 years ago

Comment by njx Friday Jun 07, 2013 at 19:06 GMT

FBNC@jodyzhang

core-ai-bot commented 3 years ago

Comment by jodyzhang Monday Jun 10, 2013 at 15:30 GMT

verified, now it finds local method, closed it.