search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Resizer: POSITION_BOTTOM and POSITION_LEFT have not yet been implemented #3714

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Friday May 24, 2013 at 17:59 GMT Originally opened as https://github.com/adobe/brackets/issues/3990

Old Subject: Panels that resize from the bottom edge (Resizer.POSITION_BOTTOM) don't work right

Write some JS code that does this:

  1. Insert a panel above the editor: $("#editor-holder").before($myPanel);
  2. Call Resizer.makeResizable($myPanel, Resizer.DIRECTION_VERTICAL, Resizer.POSITION_BOTTOM, 0) on it
  3. Drag bottom edge
  4. Drag top edge

Result: Nothing happens when you drag the bottom edge. But when you drag the top edge, the bottom edge of the panel moves.

Expected: Resize by dragging the bottom edge.

Fyi@jbalsas. I noticed this when someone was accidentally using Resizer.POSITION_BOTTOM on a bottom panel :-)

core-ai-bot commented 3 years ago

Comment by redmunds Friday May 24, 2013 at 20:52 GMT

Resizer.POSITION_BOTTOM and Resizer.POSITION_LEFT have not yet been implemented. Updating title. They're not even exported.

core-ai-bot commented 3 years ago

Comment by gruehle Wednesday Jun 05, 2013 at 22:12 GMT

Reviewed, marked "move to backlog"

core-ai-bot commented 3 years ago

Comment by njx Thursday Aug 15, 2013 at 06:38 GMT

I didn't want to make a card just for this, but we did have an existing (empty) card for making it easier to create panels from extensions. Since I think that's the main reason we would do this, I added this to that card: https://trello.com/c/AW1SbUZu/553-setup-scaffolding-example-panels-for-extensions

(If we do end up doing some core feature that requires a right panel, I think we would just naturally fix it then.)

Closing as on backlog.