search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [Core]: There is layout problem about the inline Quick Docs when Hide/Show sidebar. #3737

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by dil77307 Wednesday May 29, 2013 at 06:04 GMT Originally opened as https://github.com/adobe/brackets/issues/4014

Problem: ​There is layout problem about the Quick Docs when Hide/Show sidebar.

Method: ​1. Launch Brackets, and load the sample file.

  1. In the CSS file, selected one line and right click to choose "Quick Docs"
  2. Click View > Hide Sidebar, check the layout of Quick Docs.
  3. Make sure Quick Docs display correctly, then Click View > Show Sidebar, check the layout of Quick Docs.

Result: ​For step 3, there is some blank area besides the inline Quick Docs. For step 4, some content of the inline Quick Docs cannot be displayed completely.

Expect: ​There is no layout problem in the Quick Docs when Hide/ Show Sidebar.

Build info: Win: 0.25.0-7701 Mac: 0.25.0-7701

Workaround: Put the cursor in the property name and right click to select "Quick Docs" to reload the Quick Docs.

Screenshot: Hide Sidebar: hide sidebar Show Sidebar: show sidebar2

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday May 29, 2013 at 14:30 GMT

I could swear this was filed by Jason before, but it must have fallen off the radar.

Should be simple to fix. Ideally, EditorManager would listen either to the sidebar's Resizer events, or to PanelManager.editorAreaResized in general, and then notify all open inline widgets that their size has changed (via a new InlineWidget API). Or for a simpler fix we could just require all inlines that care to manually register their own resize listeners...

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday May 29, 2013 at 14:30 GMT

Actually, I think in this case the inline widget doesn't need to get programmatically notified at all, as long as the host Editor fixes up the widget's width correctly. Normally, the widget's width is owned/maintained by its containing CodeMirror instance...

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Jun 05, 2013 at 22:37 GMT

Reviewed. Assigning to@jasonsanjose.

core-ai-bot commented 3 years ago

Comment by julieyuan Wednesday Sep 18, 2013 at 06:29 GMT

This issue has already fixed in build 0.31.0-9518. So closing it. Here are the snapshots for reference: 4014 4014-2