[CLOSED] jQuery 1.8 deprecations

[core-ai-bot]

Issue by dangoor Wednesday May 29, 2013 at 13:24 GMT Originally opened as https://github.com/adobe/brackets/issues/4018

---

This issue is tracking the verification that we're not going to be bitten by any of the following jQuery 1.8 deprecations/removals/changes. For details on any of the items, look at the jQuery 1.8 release announcement

• [x] $(element).data("events") – undocumented, not likely in use
• [x] Deferred.isResolved() and Deferred.isRejected() – replaced with Deferred.state()
• [x] $(element).closest(Array) returning Array – only use the normal versions that return jQuery objects
• [x] $.curCSS – should not be in use anyhow. just an alias for jQuery.css()
• [x] $.attrFn – undocumented, should not be in use
• [x] jqXHR.success, jqXHR.error
• [x] Deferred with sync $.ajax
• [x] jQuery#size() in favor of jQuery#length
• [x] exclusive events (containing a !) on trigger
• [x] $(document).bind("ready or $(document).on("ready
• [x] .load, .unload, .error
• [x] :text, :radio, :checkbox, :image, :password, :reset, :submit – shorthand for [type="text"] when searching

[core-ai-bot]

Comment by dangoor Wednesday May 29, 2013 at 14:51 GMT

---

I found the following deprecated function uses:

• [x] jstree uses :checkbox
• [x] jstree uses .sze()
• [x] jstree has jqXHR.success
• [x] jasmine-jquery uses .size()
• [x] jquery.mockjax has jqXHR.success
• [ ] smart autocomplete has jqXHR.success

[core-ai-bot]

Comment by pthiess Wednesday May 29, 2013 at 18:40 GMT

---

Reviewed - This is part of this sprint story card to Upgrade jQuery.@dangoor Instead of putting a priority the importance is given by the milestone already which should be accurate, do you agree?

[core-ai-bot]

Comment by dangoor Wednesday May 29, 2013 at 18:58 GMT

---

Note that@TuckerWhitehouse has also spotted use of Deferred.pipe which was deprecated in 1.8:

https://github.com/adobe/brackets/wiki/Research:-jQuery-2.0-Upgrade

(I wish 1.8 had an upgrade guide! That one was not very obvious from the release notes.)

[core-ai-bot]

Comment by dangoor Wednesday May 29, 2013 at 19:33 GMT

---

jstree's use of .success is fine (it's not .success on a promise from jquery).

[core-ai-bot]

Comment by dangoor Wednesday May 29, 2013 at 19:54 GMT

---

We don't hit the code path of Smart Autocomplete's deprecated .success call. That's a good thing, because it's currently brought in as a submodule from its original source.

[core-ai-bot]

Comment by dangoor Thursday May 30, 2013 at 15:54 GMT

---

I've put up a pull request for Smart Autocomplete's use of .success, but this need not be a blocker for our work here.

[core-ai-bot]

Comment by njx Wednesday Jun 05, 2013 at 22:25 GMT

---

@dangoor - looks like we can close this now since the remaining issue doesn't really need to be tracked. Feel free to reopen if necessary.