[CLOSED] Changed Jump-To-Definition, as requested -- modeled on QuickEdit:

[core-ai-bot]

Issue by jeffkenton Wednesday May 29, 2013 at 14:09 GMT Originally opened as https://github.com/adobe/brackets/pull/4020

---

• Now can register multiple jump-to-definition providers (only one, so far).
  • Moved jump-to-definition menu setup to top level.
  • Added jump-to-definition to floating right-click menu. [ Note: we may not want this unless there is a provider registered for the current mode, but that's how QuickEdit does it. We can fix both at the same time if we decide to. Also note that if we want to change the right-click menu for this, one could argue that we should also change the top level menu for the same reason. ]

---

jeffkenton included the following code: https://github.com/adobe/brackets/pull/4020/commits

[core-ai-bot]

Comment by peterflynn Wednesday May 29, 2013 at 14:24 GMT

---

We might want to wait until we have infrastructure to make context menus more dynamic -- otherwise it may be confusing that the menu item is visible everywhere but only does something in JS files.

[core-ai-bot]

Comment by jeffkenton Wednesday May 29, 2013 at 14:35 GMT

---

OK. Commented out Jump-To-Definition from right-click context menu (but not from top-level menu).

[core-ai-bot]

Comment by dangoor Thursday May 30, 2013 at 14:38 GMT

---

@jeffkenton Menu enablement will definitely require some API changes, but you're right that Quick Edit has the same problem and we can solve that all at once.

I'm done with the initial review and will take another look after fixes are in place. Thanks!

[core-ai-bot]

Comment by jeffkenton Friday May 31, 2013 at 14:06 GMT

---

@dangoor: comments addressed. Thanks.