search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fix language manager test (Issue #3957) #3817

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by thefirstofthe300 Wednesday Jun 05, 2013 at 08:12 GMT Originally opened as https://github.com/adobe/brackets/pull/4097

Due to the difficulties of getting Brackets to even run on a Linux machine, I have not been able to test this code for unit testing.

I think that this code should fix the problem by testing to see if a random file extension exists in the file extension's array instead of testing to see if the arrays are identical.

thefirstofthe300 included the following code: https://github.com/adobe/brackets/pull/4097/commits

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Jun 05, 2013 at 18:08 GMT

@DaBungalow Thanks for taking this one on!

It's frustrating when unit tests pass/fail randomly, so I randomly choosing 1 file extension from list is not a good idea. I think the test should loop through all file extensions in the test to verify that they are defined in Brackets. Then we can track down the exact ones that fail.

Also, when I look in the Files Changed tab, I see changes to a lot of files that I don't think you changed, so I think this may be a bad merge. It might be easiest to start with a new branch and a new pull request.

core-ai-bot commented 3 years ago

Comment by thefirstofthe300 Wednesday Jun 05, 2013 at 18:36 GMT

Yeah. You are right. I think I messed up the merge from upstream. Oops. Still getting the hang of the Git workflow.

I now have a Win7 virtual machine running and I am having duplicating the error trouble. Can you explain what you do to get the error? That would help me solve the problem.

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Jun 05, 2013 at 18:45 GMT

The test is currently passing. The problem is that any time a new file extension is added to the HTML mode, the test fails. We want it to continue to pass.

An easy way to see this is to temporarily remove one of the file extensions from the fileExtensions array for html mode.

core-ai-bot commented 3 years ago

Comment by thefirstofthe300 Wednesday Jun 05, 2013 at 20:23 GMT

I have now opened a new pull request with just the LanguageManager-test.js file changed. #4106