[CLOSED] Fix for Issue #3942: QuickEdit ignoring .html files

[core-ai-bot]

Issue by jeffkenton Thursday Jun 06, 2013 at 13:59 GMT Originally opened as https://github.com/adobe/brackets/pull/4120

---

Fix for Issue #3942: [quick edit] in HTML file, quick editor shows function found from other file, not one in current file

The Jump-To-Definition part of the search was finding the function in the .html file, but the following part of the search -- the old QuickEdit search -- only looked in .js files.

---

jeffkenton included the following code: https://github.com/adobe/brackets/pull/4120/commits

[core-ai-bot]

Comment by njx Friday Jun 07, 2013 at 00:04 GMT

---

Reviewed--just one cleanup needed.

[core-ai-bot]

Comment by jeffkenton Friday Jun 07, 2013 at 12:21 GMT

---

Good suggestion. Done.

[core-ai-bot]

Comment by njx Friday Jun 07, 2013 at 18:53 GMT

---

Re-reviewed--just a couple of minor nits. Ready to go once those are fixed.

It looks like the submodule SHAs are showing up as diffs, but I'm not sure why since it looks like they're at the same SHAs as master. After I merge into master, we should have@eztierney double-check and make sure they're at the right SHAs.

[core-ai-bot]

Comment by jeffkenton Friday Jun 07, 2013 at 18:56 GMT

---

Nits fixed.

[core-ai-bot]

Comment by eztierney Friday Jun 07, 2013 at 19:01 GMT

---

looks like the same SHAs - I'm guessing there was some branch switching and the submodules didn't get updated before a commit, so the ones from master leaked into the branch with these changes.

[core-ai-bot]

Comment by jeffkenton Friday Jun 07, 2013 at 19:03 GMT

---

I think that's right. All the magic of Git.

[core-ai-bot]

Comment by njx Friday Jun 07, 2013 at 19:05 GMT

---

Yeah, it's just weird because I think the diff is supposed to figure that out.

Thanks for the fixes--merging.