search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Error indexing files #3881

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by rickbenetti Monday Jun 10, 2013 at 14:10 GMT Originally opened as https://github.com/adobe/brackets/issues/4178

erro_brackets_indexending_files

This error occurre always when I open my magento projects.

core-ai-bot commented 3 years ago

Comment by pthiess Monday Jun 10, 2013 at 18:42 GMT

Assigned at@JeffryBooher

core-ai-bot commented 3 years ago

Comment by JeffryBooher Monday Jun 10, 2013 at 18:44 GMT

The file index manager is set to stop after 10,000 files are indexed so the quick fix is to bump 10,000 to 50,000 but longer term we'll be looking at removing this functionality in into a web worker and tie it in with a file watcher to monitor changes to files at the filesystem and reindex them.

core-ai-bot commented 3 years ago

Comment by dangoor Tuesday Jun 11, 2013 at 14:06 GMT

Are there going to be evil side effects from bumping it to 50,000? (Things that are too slow, or too much memory usage?) That limit was added before I started working on the project, and I'm thinking there must be some reason the limit was put there to begin with.

core-ai-bot commented 3 years ago

Comment by gruehle Tuesday Jun 11, 2013 at 17:36 GMT

The 10,000 limit was arbitrary. We should check performance to make sure it doesn't bog things down too much.

core-ai-bot commented 3 years ago

Comment by rickbenetti Thursday Jun 13, 2013 at 17:10 GMT

It's possible maybe brackets read my .gitignore and not charge this folders and files? Maybe I spoke cheat I don`t know.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Thursday Jun 13, 2013 at 18:42 GMT

@rickbenetti That's an interesting proposition. We have this story on the backlog https://trello.com/c/LgdleOVx to provide a way to exclude things from brackets. I've added "read .gitignore file" to that story but that is a little of the scope for this issue.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Thursday Jun 13, 2013 at 19:33 GMT

So I tested this with a 15,000+ source file project (really an 8,000 source file angular project that a I replicated the frameworks folder and got it up to around 15,000 files). The indexer hits the limit at 10,000 files so that was what we were trying to fix so I bumped up the indexer to 50,000 as we discussed and it didn't hit the limit but QuickOpen was a little slow -- especially when using backspace for some reason. I'm not sure if it was a background process or why backspace was an issue but it was. I reduced the file set back down to around 8,000 and it was still a little sluggish. I tried brackets which was around 6,100 files and quick open performance felt a little better but not great. The brackets/src folder only has around 3,628 files (this is my typical workflow) and quick open feels good.

We may want to limit this to 15,000 instead of 50,000.@rickbenetti do you have any thoughts on what your upper limit needs to be for your magento project? Until we can implement a much more manageable solution?

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Jun 13, 2013 at 21:13 GMT

Can we put this value in a .json file so it would be easy for users to easily change it?

core-ai-bot commented 3 years ago

Comment by JeffryBooher Thursday Jun 13, 2013 at 23:01 GMT

@redmunds how about brackets.config.json? I don't see any other suitable app config/preferences json files or are you suggesting to create a new one?

core-ai-bot commented 3 years ago

Comment by rickbenetti Thursday Jun 13, 2013 at 23:58 GMT

@JeffryBooher I'm check for example some project I working know and have 16.000 files, and not have the 2000 products image, maybe 20.000 its a good limit, if that story go ahead will be nice, today my Sublime Text 2 read my .gitignore and really help us so much.

I think other thing, if brackets create a config file per project (folder project) where we put some especifications like how much deep need this file indexing, if need read a .gitignore or other something file, well I think will interesting to all, what you think?

core-ai-bot commented 3 years ago

Comment by dangoor Friday Jun 14, 2013 at 02:26 GMT

@JeffryBooher backspace is slow in Quick Open because it invalidates the cached work that it had done. I have some ideas on how to significantly speed up Quick Open and hope to try those out soon (possibly during the coming innovation days).

I have written up a proposal for a new model for preferences which includes the notion of having project-level preferences. I expect that we'll get a bit more concrete about that soon in the extension API research story.

What if we had a time-based limit rather than a number-of-files based limit? Something like the browser's "slow javascript" warning.

@rickbenetti one other thing that may help with this for you is if it's possible to open Brackets in a specific sub-directory of your project, rather than at the root. Obviously, we want to be able to handle large projects gracefully, but it's not there yet, and if you find yourself not needing to be at the root you can make it all run faster.

core-ai-bot commented 3 years ago

Comment by rickbenetti Friday Jun 14, 2013 at 12:52 GMT

Hi@dangoor my problem is because I have 2 or 3 directories I need access, magento using MVC and have their themes especifications in 2 things:

App/design/frontend/
Skin/frontend/

And if I need saw the JS used in system I need acess to:

js/

And I have my modules this modules are instaled inside this folder:

App/

Well its this folders, together they have 11.000 files, because this folders I think will be better if Brackets can read my .gitignore or .cvsignore or something else like presented here in this backlog https://trello.com/c/LgdleOVx like@JeffryBooher show more above.

core-ai-bot commented 3 years ago

Comment by dangoor Friday Jun 14, 2013 at 13:20 GMT

@rickbenetti Yeah, that makes sense. The Brackets project is the same way (I find myself editing files at /src and /test all the time).

A combination of better ignoring and better performance for file indexing (or, more likely, file watching) are definitely the real solution here.

core-ai-bot commented 3 years ago

Comment by redmunds Friday Jun 14, 2013 at 16:09 GMT

@JeffryBooher I am not sure what the distinction is between brackets.config.json and config.json -- anyone? Prefs may even belong in a different .json file. We should discuss it in today's standup meeting.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Monday Jun 17, 2013 at 20:49 GMT

src/brackets.config.json is merged with the top-level package.json into this generated config.json. We do this to remove some redundancy. The settings here are overall app settings for configuration tasks to enable Edge Code to do it's own branding, set URLs, etc.

core-ai-bot commented 3 years ago

Comment by csantanapr Wednesday Jul 17, 2013 at 03:49 GMT

+1 on bumping to 15,000 for now, I'm using dojotoolkit (dojotoolkit.org) and my project has 12,142 files My project is 20 files, dojo the rest :-(

Any thoughts about typescript for indexing? Maybe a dojo.d.ts could be created at least for autocompletion and syntax checking

Keep the good work.

core-ai-bot commented 3 years ago

Comment by dangoor Thursday Jul 18, 2013 at 13:41 GMT

@csantanapr I agree that 15,000 seems better than the current 10,000 at least. I do think we'll have a better solution soon.

We use Tern for JavaScript code completion, and I believe Tern is able to make use of .def.ts files. We have a number of things we need to do to support projects with larger numbers of files.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Tuesday Jul 23, 2013 at 17:15 GMT

FBNC to@rickbenetti

@rickbenetti, I upped the limit to 16,000. Let us know if you still see a problem.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Friday Sep 06, 2013 at 22:24 GMT

Closing this issue as it appears to be fixed.

core-ai-bot commented 3 years ago

Comment by redtopia Friday Jan 31, 2014 at 01:06 GMT

I'm getting this error. My project has 30,000 files, which includes a large data folder with lots of media files in it. Any chance there's a workaround for me? I just want my code files indexed. Can I somehow specify file extensions to index?

core-ai-bot commented 3 years ago

Comment by redmunds Friday Jan 31, 2014 at 01:48 GMT

@redtopia Try the experimental extension at: https://github.com/gruehle/exclude-folders to exclude some of your folders.

core-ai-bot commented 3 years ago

Comment by redtopia Saturday Feb 01, 2014 at 00:39 GMT

Looks like I still have about 25,000 files and am still running into the error... do you know if this issue will ever be resolved in a more permanent way?

core-ai-bot commented 3 years ago

Comment by redmunds Saturday Feb 01, 2014 at 17:03 GMT

In Sprint 36 (which will be out soon) support for File Watchers was added, which greatly reduces (eliminates?) file indexing overhead. So, we should be able to greatly increase or eliminate this limit in the near future. Please remind us if we forget!

core-ai-bot commented 3 years ago

Comment by johnnyfreeman Wednesday Feb 19, 2014 at 13:35 GMT

I'm still getting the "Error Indexing Files" message. It usually follows a 30-60 second freeze upon startup of a large project.

I'm on Arch Linux using the brackets-git package.

About Brackets shows:

sprint 37 experimental build 0.37.0-0

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Feb 19, 2014 at 18:29 GMT

@johnnyfreeman This means you have over 30,000 files in your project. Are you opening a root folder which includes many different projects under it? Brackets works best when you open a single project at a time.

If not, do you have a sense of where the huge number of files is coming from? If there's a large set of files that you don't care about viewing/editing in Brackets -- e.g. a single folder with thousands of images, or a node_modules subtree with thousands of files under it -- you may want to try the Exclude Folders extension.

core-ai-bot commented 3 years ago

Comment by johnnyfreeman Wednesday Feb 19, 2014 at 18:40 GMT

@peterflynn That looks perfect! Thanks for the tip!

core-ai-bot commented 3 years ago

Comment by unyo Thursday Sep 18, 2014 at 20:58 GMT

please allow us to set some kind of indexing limit, or somehow make sure that the indexing process/thread doesn't use up all the cpu

core-ai-bot commented 3 years ago

Comment by TheNemus Monday Jan 12, 2015 at 14:45 GMT

I'm still having this issue with a 21.000 files project with Brackets Release 1.1 build 1.1.0-15558 (release ea908cae5)

core-ai-bot commented 3 years ago

Comment by demisx Thursday Jan 29, 2015 at 20:03 GMT

Exclude Folders extension excludes folders from the view as well. We need a way to exclude globs from indexing, but make still make it visible in the project tree. We need to be able to access the contents of 'node_modules/' folder.

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Jan 29, 2015 at 21:30 GMT

@TheNemus Can you file a new bug? You should not see this message with < 30,000 files.

@demisx Planning is currently ongoing for exactly that. Please upvote or watch this item on our feature backlog: File exclusion/filtering beyond Find in Files.