search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fix #4268: Performace Data window cannot be closed. #3953

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by TomMalbran Tuesday Jun 18, 2013 at 20:15 GMT Originally opened as https://github.com/adobe/brackets/pull/4270

4268

I added a class ID to the performance dialog to be able to close it.

TomMalbran included the following code: https://github.com/adobe/brackets/pull/4270/commits

core-ai-bot commented 3 years ago

Comment by njx Tuesday Jun 18, 2013 at 20:18 GMT

@TomMalbran - I'm a little confused by this pull request--I can already close the perf dialog in master. (The close button bug was fixed by https://github.com/adobe/brackets/pull/4208, I believe.)

core-ai-bot commented 3 years ago

Comment by TomMalbran Tuesday Jun 18, 2013 at 20:25 GMT

Sorry, was using sprint 26 when I tested and not the latest version from GitHub as I thought, which made it not work. Closing this then.