[CLOSED] Inline editor's file name label should use same font as rest of our UI

brackets-archive / bracketsIssues

Archive of issues in brackets.

0 stars 0 forks source link

[CLOSED] Inline editor's file name label should use same font as rest of our UI #402

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Saturday Mar 03, 2012 at 21:58 GMT Originally opened as https://github.com/adobe/brackets/issues/404

Open any inline editor

Result: ~~The tab in the upper right showing the filename uses a serif font. (Looks like default Times New Roman).~~ The tab in the upper right uses Lucida Grande, while the rest of our UI uses the Bootstrap standard font, Helvetica Neue.

Expected: Font should match the rest of our UI ~~(or at least, it should be sans-serif)~~.

core-ai-bot commented 3 years ago

Comment by peterflynn Saturday Mar 03, 2012 at 22:00 GMT

I think NJ looked into this quickly and found that the tab's font is explicitly set to something that's Mac-only. I think ideally we shouldn't specify a font-family at all, and just use the same font as the rest of our UI. But at the least, we should specify a fallback like "sans" that is guaranteed to also work on Windows.

core-ai-bot commented 3 years ago

Comment by peterflynn Saturday Mar 03, 2012 at 22:22 GMT

Oops, NJ already fixed this in pull request #401. I've recast this as a low-priority cleanup for that tab to use a font consistent with the rest of the UI -- which even after #401 it does not. I have a fix for this that I can push up once the sprint is over.

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Mar 08, 2012 at 23:15 GMT

Joel merged my cleanup; closing.