search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Brackets fails to startup in Sprint 27 with latest brackets-debugger and brackets-color-picker extension #4080

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jasonsanjose Tuesday Jul 09, 2013 at 21:59 GMT Originally opened as https://github.com/adobe/brackets/issues/4404

With the brackets-debugger extension installed, Brackets will fail while loading extensions, failing to fire the APP_READY, causing the UI to appear "frozen" (project tree and editor don't load).

There are 2 fixes: (1) Fix ExtensionLoader to wrap module initialization in a try/catch block and (2) Update brackets-debugger to reference Inspector.Console.clearMessages in a callback function instead of at init time.

brackets-debugger and brackets-color-picker haven't been updated in a while, and has compatibility issues dating back to our CodeMirror v3 integration several sprints back.

WORKAROUND:

  1. Force quit Brackets
  2. Delete brackets-debugger extension manually: Mac ~/Library/Application Support/Brackets/extensions/user/brackets-debugger or Win C:\Users\USERNAME\AppData\Roaming\Brackets\extensions\user\brackets-debugger
  3. Restart Brackets
core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Jul 09, 2013 at 22:10 GMT

I wonder if brackets-debugger even intends for ExtensionLoader to call its init() function? It also wires it up to AppInit, so it looks like it's going to get called twice...

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Jul 09, 2013 at 22:12 GMT

@jasonsanjose Actually it looks like this functionality, where ExtensionLoader auto-calls any extension's public init() method, was just added in Sprint 27. So I'm almost certain brackets-debugger doesn't want us to call it. IMHO we should choose a name other than init() for this auto-calling behavior -- something that's much less likely to collide with existing code.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Jul 09, 2013 at 23:02 GMT

We can certainly change the name to load or something similar. It's odd though the brackets-debugger exported it's init function in the first place. I'm working on a separate pull request to the brackets-debugger repo to fix the runtime error.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Jul 10, 2013 at 17:38 GMT

There are other issues specific to brackets-debugger that will make it partially broken once we fix this bug:

https://github.com/jdiehl/brackets-debugger/issues/44 https://github.com/jdiehl/brackets-debugger/issues/45

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Jul 10, 2013 at 18:23 GMT

In the interim, I've intentionally broken brackets-debugger compatibility so that new installs are prevented https://github.com/jdiehl/brackets-debugger/commit/a1e429ddcdcc3e306c2c75f7c4229c31f479c686.

core-ai-bot commented 3 years ago

Comment by ghost Thursday Jul 11, 2013 at 13:04 GMT

The brackets-color-picker extension also causes the same thing.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Thursday Jul 11, 2013 at 22:33 GMT

Confirmed fixed in 0.28.0-8300. Closing.

core-ai-bot commented 3 years ago

Comment by adrocknaphobia Tuesday Jul 23, 2013 at 18:22 GMT

PS. Great job closing this issue quickly.