search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Added ability to install extension from list of URLs #4106

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by cezarywojcik Thursday Jul 11, 2013 at 23:28 GMT Originally opened as https://github.com/adobe/brackets/pull/4433

URLs must be seperated by commas.

cezarywojcik included the following code: https://github.com/adobe/brackets/pull/4433/commits

core-ai-bot commented 3 years ago

Comment by dangoor Monday Jul 15, 2013 at 18:42 GMT

Hi,@cezarywojcik! Thanks for the effort on this.

We have some work underway in the Extension Manager that will make installing extensions much quicker/easier in general and we're hesitant to make any unrelated changes to extension installation right now.

What were you trying to do that prompted this change? I want to be sure that we're making whatever it was you're trying to do easier.

core-ai-bot commented 3 years ago

Comment by cezarywojcik Monday Jul 15, 2013 at 18:48 GMT

I was installing Brackets on multiple systems and wanted a quick way to install all the extensions that I want.

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Jul 15, 2013 at 19:47 GMT

@cezarywojcik Sounds like you'd be interested in a sync extensions across computers feature then? Please upvote that user story if so.

Another feature we've considered is the ability to distribute "extensions packs" that group together several related extensions. That would be another way to accomplish what you want. I'm not sure if we have a user story logged for that idea yet though...

core-ai-bot commented 3 years ago

Comment by cezarywojcik Tuesday Jul 16, 2013 at 00:00 GMT

Some way to do packs is exactly what I'd be looking for. That way, people could just post a list of extensions that you can copy and paste into Brackets to install them all.

core-ai-bot commented 3 years ago

Comment by dangoor Friday Aug 16, 2013 at 15:01 GMT

@cezarywojcik Sorry for the delay on this. I'd like to get this landed, but I noticed that the Install Extension Dialog unit test is failing. (This also needs a merge with master, apparently.) I may be able to make those changes myself, but I thought I'd give you a chance to update this pull request if you have time.

Thanks!

core-ai-bot commented 3 years ago

Comment by cezarywojcik Saturday Aug 17, 2013 at 01:54 GMT

I merged to upstream; all unit tests passed.

core-ai-bot commented 3 years ago

Comment by dangoor Wednesday Oct 23, 2013 at 15:01 GMT

I took a deeper look at this. I should have realized when you said "all unit tests passed" that I should have mentioned that it's the "Install Extension Dialog" integration test that was failing. I fixed the failing tests by moving the splitting of the URL string from handleOk to the state change for valid URLs.

I re-merged everything with master and converted _installQueue to an instance variable. When I tried out the functionality, though, I realized that there's a user experience problem here... if one of the extensions you install needs updating or is going to be overwritten, I don't think the behavior is very clear because Brackets warns the user about overwrites and also explains for updates that the update gets installed when Brackets is quit.

Of course, if you don't enter multiple URLs you wouldn't encounter this, but we don't generally want to have features in the core that have behavior that will be confusing to users.

Sorry again for how long it has taken to get through this, but the workings of the install extension dialog are a little complicated and seemingly simple changes can have issues.

I have pushed my changes to a branch in case you want to look at this further. Feel free to create a pull request against that branch. Now that I'm more familiar with the issues here, I think I could get to it faster than this initial request.